Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: avoid unnecessary options checks when options argument is not passed #53861

Merged
merged 1 commit into from
Jul 17, 2024
Merged

fs: avoid unnecessary options checks when options argument is not passed #53861

merged 1 commit into from
Jul 17, 2024
+9 −8

Conversation

JonasBa
Copy link
Contributor

@JonasBa JonasBa commented Jul 15, 2024 •
edited
Loading

Remove unnecessary option parsing when options argv is undefined

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jul 15, 2024
@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 15, 2024
@anonrig
Copy link
Member

anonrig commented Jul 15, 2024

cc @nodejs/fs

@anonrig anonrig removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2024
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60346/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60347/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 16, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 17, 2024
@nodejs-github-bot nodejs-github-bot merged commit bcec922 into nodejs:main Jul 17, 2024
56 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in bcec922

@H4ad
Copy link
Member

H4ad commented Jul 18, 2024

@JonasBa Congratz on your first PR o/

ehsankhfr pushed a commit to ehsankhfr/node that referenced this pull request Jul 18, 2024
@JonasBa @ehsankhfr
fs: remove unnecessary option argument validation
152888c 
PR-URL: nodejs#53861
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
targos pushed a commit that referenced this pull request Jul 28, 2024
@JonasBa @targos
fs: remove unnecessary option argument validation
8086337 
PR-URL: #53861
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
Merged
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

@H4ad H4ad H4ad approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JonasBa @anonrig @nodejs-github-bot @H4ad @jasnell @targos