Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix c-ares update script #53414

Merged
merged 1 commit into from
Jun 13, 2024
Merged

tools: fix c-ares update script #53414

merged 1 commit into from
Jun 13, 2024

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Jun 11, 2024 •
edited
Loading

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 11, 2024 •
edited by marco-ippolito
Loading

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 11, 2024
@marco-ippolito marco-ippolito force-pushed the feat/fix-c-ares-script branch 2 times, most recently from 22fc5a7 to 64248a8 Compare June 11, 2024 07:42
@anonrig

This comment was marked as resolved.

Sign in to view
@marco-ippolito marco-ippolito force-pushed the feat/fix-c-ares-script branch from 64248a8 to 7edcb34 Compare June 11, 2024 08:29
@marco-ippolito marco-ippolito changed the title tools: fixed c-ares update script tools: fix c-ares update script Jun 11, 2024
@marco-ippolito marco-ippolito added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 12, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2024
@nodejs-github-bot nodejs-github-bot merged commit c64a00a into nodejs:main Jun 13, 2024
24 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c64a00a

targos pushed a commit that referenced this pull request Jun 20, 2024
@marco-ippolito @targos
tools: fix c-ares update script
fe85e05 
PR-URL: #53414
Fixes: #53407
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sophoniie pushed a commit to sophoniie/node that referenced this pull request Jun 20, 2024
@marco-ippolito @sophoniie
tools: fix c-ares update script
a30fef1 
PR-URL: nodejs#53414
Fixes: nodejs#53407
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@marco-ippolito @bmeck
tools: fix c-ares update script
4c404b7 
PR-URL: nodejs#53414
Fixes: nodejs#53407
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jun 25, 2024
Merged
@Karliz24 Karliz24 mentioned this pull request Jul 9, 2024
Open
marco-ippolito added a commit that referenced this pull request Jul 19, 2024
@marco-ippolito
tools: fix c-ares update script
1988714 
PR-URL: #53414
Fixes: #53407
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito added a commit that referenced this pull request Jul 19, 2024
@marco-ippolito
tools: fix c-ares update script
53a7b6e 
PR-URL: #53414
Fixes: #53407
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

c-ares update script broken by c-ares 1.30.0
6 participants
@marco-ippolito @nodejs-github-bot @anonrig @lpinca @richardlau @RafaelGSS