stream: micro-optimize writable condition #53189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
ronag
approved these changes
May 28, 2024
benjamingr
approved these changes
May 28, 2024
|
Can you please run the CI? |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
orgads
changed the title
|
The commit message had |
github-actions
bot
removed
the
request-ci
MoLow
added
the
author ready
github-actions
bot
removed
the
request-ci
|
Rebased, please retrigger CI. |
github-actions
bot
removed
the
request-ci
|
Are these failing tests known to be flaky? |
|
let's see |
github-actions
bot
removed
the
request-ci
|
Finally! |
mcollina
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/53189 ✔ Done loading data for nodejs/node/pull/53189 ----------------------------------- PR info ------------------------------------ Title stream: micro-optimize writable condition (#53189) Author Orgad Shaneh (@orgads) Branch orgads:streams-uoptimize -> nodejs:main Labels author ready Commits 1 - stream: micro-optimize writable condition Committers 1 - Orgad Shaneh PR-URL: https://github.com/nodejs/node/pull/53189 Reviewed-By: Robert Nagy Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53189 Reviewed-By: Robert Nagy Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - stream: micro-optimize writable condition ℹ This PR was created on Tue, 28 May 2024 19:30:07 GMT ✔ Approvals: 3 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/53189#pullrequestreview-2083817619 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/53189#pullrequestreview-2083824949 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53189#pullrequestreview-2085069824 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-06-02T18:30:19Z: https://ci.nodejs.org/job/node-test-pull-request/59621/ - Querying data for job/node-test-pull-request/59621/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9364333050 |
mcollina
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7d14d1f |
RafaelGSS
pushed a commit
that referenced
this pull request
Jun 7, 2024
PR-URL: #53189 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
EliphazBouye
pushed a commit
to EliphazBouye/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53189 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#53189 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53189 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53189 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.