Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve for httpVersionMajor & httpVersionMinor #5296

Closed
wants to merge 1 commit into from

Conversation

JacksonTian
Copy link
Contributor

The description of httpVersionMajor & httpVersionMinor should
have same context like httpVersion.

The description of httpVersionMarjor & httpVersionMinor should
have same context like httpVersion.
@mscdex mscdex added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. labels Feb 18, 2016
@silverwind silverwind changed the title doc: improve for httpVersionMarjor & httpVersionMinor doc: improve for httpVersionMajor & httpVersionMinor Feb 18, 2016
@jasnell
Copy link
Member

jasnell commented Feb 19, 2016

LGTM

@silverwind
Copy link
Contributor

Thanks! Landed in c6ae7d0.

@silverwind silverwind closed this Feb 27, 2016
silverwind pushed a commit that referenced this pull request Feb 27, 2016
The description of httpVersionMajor & httpVersionMinor should
have same context like httpVersion.

PR-URL: #5296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg pushed a commit that referenced this pull request Feb 28, 2016
The description of httpVersionMajor & httpVersionMinor should
have same context like httpVersion.

PR-URL: #5296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@Fishrock123 Fishrock123 mentioned this pull request Mar 1, 2016
5 tasks
@jasnell
Copy link
Member

jasnell commented Mar 2, 2016

Added the lts watch label...

@JacksonTian JacksonTian deleted the http_version branch March 3, 2016 02:31
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
The description of httpVersionMajor & httpVersionMinor should
have same context like httpVersion.

PR-URL: #5296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
The description of httpVersionMajor & httpVersionMinor should
have same context like httpVersion.

PR-URL: #5296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants