-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: limit stack size in test-error-serdes
#52674
Closed
LiviaMedeiros
wants to merge
2
commits into
nodejs:main
from
LiviaMedeiros:test-maybe-deflake-error-serdes
+87
−17
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
// Flags: --expose-internals --stack-size=128 | ||
'use strict'; | ||
require('../common'); | ||
const assert = require('assert'); | ||
const { serializeError, deserializeError } = require('internal/error_serdes'); | ||
|
||
function cycle(err) { | ||
return deserializeError(serializeError(err)); | ||
} | ||
|
||
class ErrorWithCyclicCause extends Error { | ||
get cause() { | ||
return new ErrorWithCyclicCause(); | ||
} | ||
} | ||
const errorWithCyclicCause = Object | ||
.defineProperty(new Error('Error with cause'), 'cause', { get() { return errorWithCyclicCause; } }); | ||
|
||
assert.strictEqual(Object.hasOwn(cycle(errorWithCyclicCause), 'cause'), true); | ||
|
||
// When the cause is cyclic, it is serialized until Maxiumum call stack size is reached | ||
let depth = 0; | ||
let e = cycle(new ErrorWithCyclicCause('Error with cause')); | ||
while (e.cause) { | ||
e = e.cause; | ||
depth++; | ||
} | ||
assert(depth > 1); | ||
console.log('Successfully completed stack exhaust test at', depth); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
// Flags: --expose-internals --stack-size=3072 | ||
'use strict'; | ||
require('../common'); | ||
const assert = require('assert'); | ||
const { serializeError, deserializeError } = require('internal/error_serdes'); | ||
|
||
function cycle(err) { | ||
return deserializeError(serializeError(err)); | ||
} | ||
|
||
class ErrorWithCyclicCause extends Error { | ||
get cause() { | ||
return new ErrorWithCyclicCause(); | ||
} | ||
} | ||
const errorWithCyclicCause = Object | ||
.defineProperty(new Error('Error with cause'), 'cause', { get() { return errorWithCyclicCause; } }); | ||
|
||
assert.strictEqual(Object.hasOwn(cycle(errorWithCyclicCause), 'cause'), true); | ||
|
||
// When the cause is cyclic, it is serialized until Maxiumum call stack size is reached | ||
let depth = 0; | ||
let e = cycle(new ErrorWithCyclicCause('Error with cause')); | ||
while (e.cause) { | ||
e = e.cause; | ||
depth++; | ||
} | ||
assert(depth > 1); | ||
console.log('Successfully completed stack exhaust test at', depth); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
// Flags: --expose-internals | ||
'use strict'; | ||
require('../common'); | ||
const assert = require('assert'); | ||
const { serializeError, deserializeError } = require('internal/error_serdes'); | ||
|
||
function cycle(err) { | ||
return deserializeError(serializeError(err)); | ||
} | ||
|
||
class ErrorWithCyclicCause extends Error { | ||
get cause() { | ||
return new ErrorWithCyclicCause(); | ||
} | ||
} | ||
const errorWithCyclicCause = Object | ||
.defineProperty(new Error('Error with cause'), 'cause', { get() { return errorWithCyclicCause; } }); | ||
|
||
assert.strictEqual(Object.hasOwn(cycle(errorWithCyclicCause), 'cause'), true); | ||
|
||
// When the cause is cyclic, it is serialized until Maxiumum call stack size is reached | ||
let depth = 0; | ||
let e = cycle(new ErrorWithCyclicCause('Error with cause')); | ||
while (e.cause) { | ||
e = e.cause; | ||
depth++; | ||
} | ||
assert(depth > 1); | ||
console.log('Successfully completed stack exhaust test at', depth); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these just three tests testing the same thing but with different stack sizes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, these belong to af75425 just to see if there's any difference in CI results on different platforms.
That commit also extracted the stack exhausting parts (primary suspect of flakiness) from the rest of the test to confirm that cyclic errors are the cause of timeout.