doc: deprecate --experimental-policy #52602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
|
Deprecated features have stronger semver guarentees than experimental features, which is why we don't deprecate experimental features we want to get rid of. However I kinda like the approach of this PR which is marking the feature as deprecated without adding an entry in |
|
We have deprecated things that were experimental before, e.g. #12243. Full removal (#52583) touches a lot more files so doc-deprecating first means we don't have to rush that through. |
marco-ippolito
approved these changes
Apr 20, 2024
|
I believe for experimental features it's good to change the stability to deprecated and remove it in a next minor, without assigning a deprecation code and going in the full cycle |
joyeecheung
approved these changes
Apr 20, 2024
|
Would be cool to do what @aduh95 suggested:
Though not necessarily in this PR. |
RafaelGSS
added
the
author ready
benjamingr
approved these changes
Apr 21, 2024
avivkeller
added
experimental
jasnell
approved these changes
Apr 21, 2024
RafaelGSS
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/52602 ✔ Done loading data for nodejs/node/pull/52602 ----------------------------------- PR info ------------------------------------ Title doc: deprecate --experimental-policy (#52602) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:doc-deprecate-policy -> nodejs:main Labels doc, experimental, author ready, deprecations, policy Commits 1 - doc: deprecate --experimental-policy Committers 1 - RafaelGSS PR-URL: https://github.com/nodejs/node/pull/52602 Reviewed-By: Marco Ippolito Reviewed-By: Joyee Cheung Reviewed-By: Moshe Atlow Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52602 Reviewed-By: Marco Ippolito Reviewed-By: Joyee Cheung Reviewed-By: Moshe Atlow Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 19 Apr 2024 19:30:13 GMT ✔ Approvals: 5 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/52602#pullrequestreview-2013052255 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/52602#pullrequestreview-2013100547 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/52602#pullrequestreview-2013333425 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/52602#pullrequestreview-2013389396 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/52602#pullrequestreview-2013491033 ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8784408408 |
RafaelGSS
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/52602 ✔ Done loading data for nodejs/node/pull/52602 ----------------------------------- PR info ------------------------------------ Title doc: deprecate --experimental-policy (#52602) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:doc-deprecate-policy -> nodejs:main Labels doc, experimental, author ready, deprecations, policy Commits 1 - doc: deprecate --experimental-policy Committers 1 - RafaelGSS PR-URL: https://github.com/nodejs/node/pull/52602 Reviewed-By: Marco Ippolito Reviewed-By: Joyee Cheung Reviewed-By: Moshe Atlow Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell Reviewed-By: Michael Dawson ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52602 Reviewed-By: Marco Ippolito Reviewed-By: Joyee Cheung Reviewed-By: Moshe Atlow Reviewed-By: Benjamin Gruenbaum Reviewed-By: James M Snell Reviewed-By: Michael Dawson -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 19 Apr 2024 19:30:13 GMT ✔ Approvals: 6 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/52602#pullrequestreview-2013052255 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/52602#pullrequestreview-2013100547 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/52602#pullrequestreview-2013333425 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/52602#pullrequestreview-2013389396 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/52602#pullrequestreview-2013491033 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/52602#pullrequestreview-2014748381 ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8784891706 |
RafaelGSS
added a commit
that referenced
this pull request
Apr 22, 2024
PR-URL: #52602 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
|
Landed in 01c281f |
RafaelGSS
added a commit
that referenced
this pull request
Apr 22, 2024
PR-URL: #52602 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52602 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52602 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #52583 (comment)