Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Rename readme.md to README.md #52471

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Conversation

avivkeller
Copy link
Member

@avivkeller avivkeller commented Apr 11, 2024

This PR renames readme.md to README.md for easier find-ability. (I know I made a typo on the commit message, I can amend it before we merge)

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 11, 2024
@avivkeller
Copy link
Member Author

Despite the need-ci label, this PR does not need a ci run.

@aduh95 aduh95 added doc Issues and PRs related to the documentations. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Apr 11, 2024
@avivkeller
Copy link
Member Author

I'm fixing the PR message now; cloning the repo is slow.

@aduh95
Copy link
Contributor

aduh95 commented Apr 11, 2024

I'm fixing the PR message now; cloning the repo is slow.

No worries, it can also be done upon landing.

@avivkeller
Copy link
Member Author

I'm fixing the PR message now; cloning the repo is slow.

No worries, it can also be done upon landing.

Renamed!

@avivkeller
Copy link
Member Author

I don't that "author ready" means I need to do anything, so are we good to merge?

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2024
@nodejs-github-bot nodejs-github-bot merged commit f8e325e into nodejs:main Apr 14, 2024
16 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f8e325e

@avivkeller avivkeller deleted the patch-5 branch April 14, 2024 10:32
aduh95 pushed a commit that referenced this pull request Apr 29, 2024
PR-URL: #52471
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
PR-URL: #52471
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
PR-URL: #52471
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants