Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove Internet Explorer mention in BUILDING.md #52455

Merged
merged 1 commit into from
Apr 10, 2024
Merged

doc: remove Internet Explorer mention in BUILDING.md #52455

merged 1 commit into from
Apr 10, 2024

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 10, 2024

No description provided.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Apr 10, 2024
@Trott Trott removed doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. labels Apr 10, 2024
@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

tniessen
tniessen approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally.

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2024
@nodejs-github-bot nodejs-github-bot merged commit 411503b into nodejs:main Apr 10, 2024
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 411503b

@RafaelGSS RafaelGSS mentioned this pull request Apr 15, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@Trott @marco-ippolito
doc: remove Internet Explorer mention in BUILDING.md
ea051dc 
PR-URL: #52455
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@marco-ippolito marco-ippolito mentioned this pull request May 2, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@Trott @marco-ippolito
doc: remove Internet Explorer mention in BUILDING.md
88adbd0 
PR-URL: #52455
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@tniessen tniessen tniessen approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @lpinca @anonrig @tniessen @UlisesGascon @richardlau