Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed template string in Crypto Documentation #5240

Closed
wants to merge 1 commit into from
Closed

Fixed template string in Crypto Documentation #5240

wants to merge 1 commit into from

Conversation

MrOutput
Copy link
Contributor

Template string was syntactically incorrect. Copied Documentation code
would throw an error.

Template string was syntactically incorrect. Copied Documentation code
would throw an error.
@mscdex mscdex added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Feb 15, 2016
@jasnell
Copy link
Member

jasnell commented Feb 15, 2016

LGTM

@tflanagan
Copy link
Contributor

dup of #5235,

@MrOutput, do you need any help in setting this PR up for landing? What's the reason you closed/deleted the last PR you opened?

@MrOutput
Copy link
Contributor Author

@tflanagan admittedly, I had difficulties amending my commit message.

@MylesBorins
Copy link
Contributor

@MrOutput in future if you need to modify a single commit message you can do so with
git commit --amed
That will open the last commit message in a text editor to modify. You will then need to force push over your old branch
git push [remote name] [branch-name] -f

If you have multiple commits you can use git rebase interactive to change stuff
git rebase -i HEAD~5 Where the number is how many commits you want to work on.

This will give you a list of commits and options for each other. You can easily squash (merge commits), delete commits, change the commit message, and more.

@MrOutput
Copy link
Contributor Author

@thealphanerd I did that but told me it could not push and that I needed to pull down again. Then I tried rebasing it. Now I see, I needed to force the push...thank you!

silverwind pushed a commit that referenced this pull request Feb 18, 2016
Template string was syntactically incorrect. Copied Documentation code
would throw an error.

PR-URL: #5240
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@silverwind
Copy link
Contributor

Thanks! Landed in 51bd770 with the commit message amended.

@silverwind silverwind closed this Feb 18, 2016
rvagg pushed a commit that referenced this pull request Feb 18, 2016
Template string was syntactically incorrect. Copied Documentation code
would throw an error.

PR-URL: #5240
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
Template string was syntactically incorrect. Copied Documentation code
would throw an error.

PR-URL: #5240
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
Template string was syntactically incorrect. Copied Documentation code
would throw an error.

PR-URL: #5240
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
Template string was syntactically incorrect. Copied Documentation code
would throw an error.

PR-URL: #5240
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants