Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 12.3 #52293

Closed
wants to merge 13 commits into from
Closed

deps: update V8 to 12.3 #52293

wants to merge 13 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Mar 31, 2024

No description provided.

@targos targos added semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency. labels Mar 31, 2024
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Mar 31, 2024
@targos
Copy link
Member Author

targos commented Mar 31, 2024

@StefanStojanovic b9d806a from the 12.2 update doesn't land cleanly (it has many conflicts).

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@targos
Copy link
Member Author

targos commented Mar 31, 2024

@RafaelGSS There UBSan build fails:

2024-03-31T14:31:31.1917522Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h: In instantiation of ‘static const absl::container_internal::PolicyFunctions& absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::GetPolicyFunctions() [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>; Eq = std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > >]’:
2024-03-31T14:31:31.1937899Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3065:72:   required from ‘void absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::drop_deletes_without_resize() [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>; Eq = std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > >]’
2024-03-31T14:31:31.1950274Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3119:7:   required from ‘void absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::rehash_and_grow_if_necessary() [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>; Eq = std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > >]’
2024-03-31T14:31:31.1962978Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3226:7:   required from ‘size_t absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::prepare_insert(size_t) [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>; Eq = std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > >; size_t = long unsigned int]’
2024-03-31T14:31:31.1977270Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3206:13:   required from ‘std::pair<long unsigned int, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::find_or_prepare_insert(const K&) [with K = v8::internal::compiler::turboshaft::MemoryAddress; Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>; Eq = std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > >]’
2024-03-31T14:31:31.1986665Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2929:12:   [ skipping 2 instantiation contexts, use -ftemplate-backtrace-limit=0 to disable ]
2024-03-31T14:31:31.2004874Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/container_memory.h:219:44:   required from ‘decltype (absl::container_internal::memory_internal::DecomposePairImpl(forward<F>(f), absl::container_internal::PairArgs((forward<Args>)(absl::container_internal::DecomposePair::args)...))) absl::container_internal::DecomposePair(F&&, Args&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>, std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > > >::EmplaceDecomposable; Args = {std::pair<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >}; decltype (absl::container_internal::memory_internal::DecomposePairImpl(forward<F>(f), absl::container_internal::PairArgs((forward<Args>)(absl::container_internal::DecomposePair::args)...))) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>, std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > > >::iterator, bool>]’
2024-03-31T14:31:31.2037304Z ../deps/v8/third_party/abseil-cpp/absl/container/flat_hash_map.h:605:51:   required from ‘static decltype (absl::container_internal::DecomposePair(declval<F>(), (declval<Args>)()...)) absl::container_internal::FlatHashMapPolicy<K, V>::apply(F&&, Args&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>, std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > > >::EmplaceDecomposable; Args = {std::pair<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >}; K = v8::internal::compiler::turboshaft::MemoryAddress; V = v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>; decltype (absl::container_internal::DecomposePair(declval<F>(), (declval<Args>)()...)) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>, std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > > >::iterator, bool>]’
2024-03-31T14:31:31.2073473Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/hash_policy_traits.h:134:20:   required from ‘static decltype (P::apply(forward<F>(f), (forward<Ts>)(absl::container_internal::hash_policy_traits::apply::ts)...)) absl::container_internal::hash_policy_traits<Policy, <template-parameter-1-2> >::apply(F&&, Ts&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>, std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > > >::EmplaceDecomposable; Ts = {std::pair<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >}; P = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >; Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >; <template-parameter-1-2> = void; decltype (P::apply(forward<F>(f), (forward<Ts>)(absl::container_internal::hash_policy_traits::apply::ts)...)) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>, std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > > >::iterator, bool>]’
2024-03-31T14:31:31.2102279Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2529:31:   required from ‘std::pair<absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::iterator, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::emplace(Args&& ...) [with Args = {std::pair<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >}; typename std::enable_if<absl::container_internal::IsDecomposable<void, absl::container_internal::hash_policy_traits<Policy>, Hash, Eq, Ts ...>::value, int>::type <anonymous> = 0; Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>; Eq = std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > >]’
2024-03-31T14:31:31.2122406Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2456:36:   required from ‘std::pair<absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::iterator, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::insert(absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::init_type&&) [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>; Eq = std::equal_to<v8::internal::compiler::turboshaft::MemoryAddress>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> > >; absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::init_type = std::pair<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >]’
2024-03-31T14:31:31.2133095Z ../deps/v8/src/compiler/turboshaft/late-load-elimination-reducer.h:504:32:   required from here
2024-03-31T14:31:31.2138164Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3335:56:   in ‘constexpr’ expansion of ‘absl::container_internal::hash_policy_traits<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::MemoryAddress, v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData> >, void>::get_hash_slot_fn<absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress> >()’
2024-03-31T14:31:31.2144834Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/hash_policy_traits.h:163:54: error: ‘(absl::container_internal::TypeErasedApplyToSlotFn<absl::hash_internal::Hash<v8::internal::compiler::turboshaft::MemoryAddress>, v8::internal::compiler::turboshaft::MemoryAddress> == 0)’ is not a constant expression
2024-03-31T14:31:31.2147730Z   163 |     return Policy::template get_hash_slot_fn<Hash>() == nullptr
2024-03-31T14:31:31.2148621Z       |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
2024-03-31T14:31:31.2154720Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h: In instantiation of ‘static const absl::container_internal::PolicyFunctions& absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::GetPolicyFunctions() [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> >]’:
2024-03-31T14:31:31.2165104Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3065:72:   required from ‘void absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::drop_deletes_without_resize() [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> >]’
2024-03-31T14:31:31.2174907Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3119:7:   required from ‘void absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::rehash_and_grow_if_necessary() [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> >]’
2024-03-31T14:31:31.2185274Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3226:7:   required from ‘size_t absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::prepare_insert(size_t) [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> >; size_t = long unsigned int]’
2024-03-31T14:31:31.2195928Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3206:13:   required from ‘std::pair<long unsigned int, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::find_or_prepare_insert(const K&) [with K = v8::internal::compiler::turboshaft::OpIndex; Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> >]’
2024-03-31T14:31:31.2202487Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2929:12:   [ skipping 2 instantiation contexts, use -ftemplate-backtrace-limit=0 to disable ]
2024-03-31T14:31:31.2216631Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/container_memory.h:219:44:   required from ‘decltype (absl::container_internal::memory_internal::DecomposePairImpl(forward<F>(f), absl::container_internal::PairArgs((forward<Args>)(absl::container_internal::DecomposePair::args)...))) absl::container_internal::DecomposePair(F&&, Args&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> > >::EmplaceDecomposable; Args = {std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>}; decltype (absl::container_internal::memory_internal::DecomposePairImpl(forward<F>(f), absl::container_internal::PairArgs((forward<Args>)(absl::container_internal::DecomposePair::args)...))) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> > >::iterator, bool>]’
2024-03-31T14:31:31.2239550Z ../deps/v8/third_party/abseil-cpp/absl/container/flat_hash_map.h:605:51:   required from ‘static decltype (absl::container_internal::DecomposePair(declval<F>(), (declval<Args>)()...)) absl::container_internal::FlatHashMapPolicy<K, V>::apply(F&&, Args&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> > >::EmplaceDecomposable; Args = {std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>}; K = v8::internal::compiler::turboshaft::OpIndex; V = v8::internal::compiler::turboshaft::BaseData; decltype (absl::container_internal::DecomposePair(declval<F>(), (declval<Args>)()...)) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> > >::iterator, bool>]’
2024-03-31T14:31:31.2264386Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/hash_policy_traits.h:134:20:   required from ‘static decltype (P::apply(forward<F>(f), (forward<Ts>)(absl::container_internal::hash_policy_traits::apply::ts)...)) absl::container_internal::hash_policy_traits<Policy, <template-parameter-1-2> >::apply(F&&, Ts&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> > >::EmplaceDecomposable; Ts = {std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>}; P = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>; Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>; <template-parameter-1-2> = void; decltype (P::apply(forward<F>(f), (forward<Ts>)(absl::container_internal::hash_policy_traits::apply::ts)...)) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> > >::iterator, bool>]’
2024-03-31T14:31:31.2284584Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2529:31:   required from ‘std::pair<absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::iterator, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::emplace(Args&& ...) [with Args = {std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>}; typename std::enable_if<absl::container_internal::IsDecomposable<void, absl::container_internal::hash_policy_traits<Policy>, Hash, Eq, Ts ...>::value, int>::type <anonymous> = 0; Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> >]’
2024-03-31T14:31:31.2299095Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2456:36:   required from ‘std::pair<absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::iterator, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::insert(absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::init_type&&) [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData> >; absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::init_type = std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>]’
2024-03-31T14:31:31.2306549Z ../deps/v8/src/compiler/turboshaft/late-load-elimination-reducer.h:579:48:   required from here
2024-03-31T14:31:31.2310580Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3335:56:   in ‘constexpr’ expansion of ‘absl::container_internal::hash_policy_traits<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::BaseData>, void>::get_hash_slot_fn<absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex> >()’
2024-03-31T14:31:31.2315652Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/hash_policy_traits.h:163:54: error: ‘(absl::container_internal::TypeErasedApplyToSlotFn<absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::compiler::turboshaft::OpIndex> == 0)’ is not a constant expression
2024-03-31T14:31:31.2324709Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h: In instantiation of ‘static const absl::container_internal::PolicyFunctions& absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::GetPolicyFunctions() [with Policy = absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >; Hash = absl::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > >]’:
2024-03-31T14:31:31.2338318Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3065:72:   required from ‘void absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::drop_deletes_without_resize() [with Policy = absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >; Hash = absl::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > >]’
2024-03-31T14:31:31.2351915Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3119:7:   required from ‘void absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::rehash_and_grow_if_necessary() [with Policy = absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >; Hash = absl::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > >]’
2024-03-31T14:31:31.2365270Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3226:7:   required from ‘size_t absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::prepare_insert(size_t) [with Policy = absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >; Hash = absl::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > >; size_t = long unsigned int]’
2024-03-31T14:31:31.2378167Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3206:13:   required from ‘std::pair<long unsigned int, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::find_or_prepare_insert(const K&) [with K = int; Policy = absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >; Hash = absl::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > >]’
2024-03-31T14:31:31.2385762Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2929:12:   [ skipping 2 instantiation contexts, use -ftemplate-backtrace-limit=0 to disable ]
2024-03-31T14:31:31.2404210Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/container_memory.h:219:44:   required from ‘decltype (absl::container_internal::memory_internal::DecomposePairImpl(forward<F>(f), absl::container_internal::PairArgs((forward<Args>)(absl::container_internal::DecomposePair::args)...))) absl::container_internal::DecomposePair(F&&, Args&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >, absl::hash_internal::Hash<int>, std::equal_to<int>, v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > > >::EmplaceDecomposable; Args = {std::pair<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >}; decltype (absl::container_internal::memory_internal::DecomposePairImpl(forward<F>(f), absl::container_internal::PairArgs((forward<Args>)(absl::container_internal::DecomposePair::args)...))) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >, absl::hash_internal::Hash<int>, std::equal_to<int>, v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > > >::iterator, bool>]’
2024-03-31T14:31:31.2437252Z ../deps/v8/third_party/abseil-cpp/absl/container/flat_hash_map.h:605:51:   required from ‘static decltype (absl::container_internal::DecomposePair(declval<F>(), (declval<Args>)()...)) absl::container_internal::FlatHashMapPolicy<K, V>::apply(F&&, Args&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >, absl::hash_internal::Hash<int>, std::equal_to<int>, v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > > >::EmplaceDecomposable; Args = {std::pair<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >}; K = int; V = v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits>; decltype (absl::container_internal::DecomposePair(declval<F>(), (declval<Args>)()...)) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >, absl::hash_internal::Hash<int>, std::equal_to<int>, v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > > >::iterator, bool>]’
2024-03-31T14:31:31.2472769Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/hash_policy_traits.h:134:20:   required from ‘static decltype (P::apply(forward<F>(f), (forward<Ts>)(absl::container_internal::hash_policy_traits::apply::ts)...)) absl::container_internal::hash_policy_traits<Policy, <template-parameter-1-2> >::apply(F&&, Ts&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >, absl::hash_internal::Hash<int>, std::equal_to<int>, v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > > >::EmplaceDecomposable; Ts = {std::pair<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >}; P = absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >; Policy = absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >; <template-parameter-1-2> = void; decltype (P::apply(forward<F>(f), (forward<Ts>)(absl::container_internal::hash_policy_traits::apply::ts)...)) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >, absl::hash_internal::Hash<int>, std::equal_to<int>, v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > > >::iterator, bool>]’
2024-03-31T14:31:31.2502483Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2529:31:   required from ‘std::pair<absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::iterator, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::emplace(Args&& ...) [with Args = {std::pair<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >}; typename std::enable_if<absl::container_internal::IsDecomposable<void, absl::container_internal::hash_policy_traits<Policy>, Hash, Eq, Ts ...>::value, int>::type <anonymous> = 0; Policy = absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >; Hash = absl::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > >]’
2024-03-31T14:31:31.2523046Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2456:36:   required from ‘std::pair<absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::iterator, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::insert(absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::init_type&&) [with Policy = absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >; Hash = absl::hash_internal::Hash<int>; Eq = std::equal_to<int>; Alloc = v8::internal::ZoneAllocator<std::pair<const int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> > >; absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::init_type = std::pair<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >]’
2024-03-31T14:31:31.2533836Z ../deps/v8/src/compiler/turboshaft/late-load-elimination-reducer.h:594:54:   required from here
2024-03-31T14:31:31.2539203Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3335:56:   in ‘constexpr’ expansion of ‘absl::container_internal::hash_policy_traits<absl::container_internal::FlatHashMapPolicy<int, v8::base::DoublyThreadedList<v8::internal::compiler::turboshaft::SnapshotTableKey<v8::internal::compiler::turboshaft::OpIndex, v8::internal::compiler::turboshaft::KeyData>, v8::internal::compiler::turboshaft::OffsetListTraits> >, void>::get_hash_slot_fn<absl::hash_internal::Hash<int> >()’
2024-03-31T14:31:31.2544943Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/hash_policy_traits.h:163:54: error: ‘(absl::container_internal::TypeErasedApplyToSlotFn<absl::hash_internal::Hash<int>, int> == 0)’ is not a constant expression
2024-03-31T14:31:31.2552586Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h: In instantiation of ‘static const absl::container_internal::PolicyFunctions& absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::GetPolicyFunctions() [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> >]’:
2024-03-31T14:31:31.2563199Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3065:72:   required from ‘void absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::drop_deletes_without_resize() [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> >]’
2024-03-31T14:31:31.2574015Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3119:7:   required from ‘void absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::rehash_and_grow_if_necessary() [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> >]’
2024-03-31T14:31:31.2584913Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3226:7:   required from ‘size_t absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::prepare_insert(size_t) [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> >; size_t = long unsigned int]’
2024-03-31T14:31:31.2596192Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3206:13:   required from ‘std::pair<long unsigned int, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::find_or_prepare_insert(const K&) [with K = v8::internal::compiler::turboshaft::OpIndex; Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> >]’
2024-03-31T14:31:31.2603633Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2929:12:   [ skipping 2 instantiation contexts, use -ftemplate-backtrace-limit=0 to disable ]
2024-03-31T14:31:31.2618514Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/container_memory.h:219:44:   required from ‘decltype (absl::container_internal::memory_internal::DecomposePairImpl(forward<F>(f), absl::container_internal::PairArgs((forward<Args>)(absl::container_internal::DecomposePair::args)...))) absl::container_internal::DecomposePair(F&&, Args&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> > >::EmplaceDecomposable; Args = {std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>}; decltype (absl::container_internal::memory_internal::DecomposePairImpl(forward<F>(f), absl::container_internal::PairArgs((forward<Args>)(absl::container_internal::DecomposePair::args)...))) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> > >::iterator, bool>]’
2024-03-31T14:31:31.2644404Z ../deps/v8/third_party/abseil-cpp/absl/container/flat_hash_map.h:605:51:   required from ‘static decltype (absl::container_internal::DecomposePair(declval<F>(), (declval<Args>)()...)) absl::container_internal::FlatHashMapPolicy<K, V>::apply(F&&, Args&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> > >::EmplaceDecomposable; Args = {std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>}; K = v8::internal::compiler::turboshaft::OpIndex; V = v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*; decltype (absl::container_internal::DecomposePair(declval<F>(), (declval<Args>)()...)) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> > >::iterator, bool>]’
2024-03-31T14:31:31.2671570Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/hash_policy_traits.h:134:20:   required from ‘static decltype (P::apply(forward<F>(f), (forward<Ts>)(absl::container_internal::hash_policy_traits::apply::ts)...)) absl::container_internal::hash_policy_traits<Policy, <template-parameter-1-2> >::apply(F&&, Ts&& ...) [with F = absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> > >::EmplaceDecomposable; Ts = {std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>}; P = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>; Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>; <template-parameter-1-2> = void; decltype (P::apply(forward<F>(f), (forward<Ts>)(absl::container_internal::hash_policy_traits::apply::ts)...)) = std::pair<absl::container_internal::raw_hash_set<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>, absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, std::equal_to<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> > >::iterator, bool>]’
2024-03-31T14:31:31.2694131Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2529:31:   required from ‘std::pair<absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::iterator, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::emplace(Args&& ...) [with Args = {std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>}; typename std::enable_if<absl::container_internal::IsDecomposable<void, absl::container_internal::hash_policy_traits<Policy>, Hash, Eq, Ts ...>::value, int>::type <anonymous> = 0; Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> >]’
2024-03-31T14:31:31.2709727Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:2456:36:   required from ‘std::pair<absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::iterator, bool> absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::insert(absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::init_type&&) [with Policy = absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>; Hash = absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>; Eq = std::equal_to<v8::internal::compiler::turboshaft::OpIndex>; Alloc = v8::internal::ZoneAllocator<std::pair<const v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*> >; absl::container_internal::raw_hash_set<Policy, Hash, Eq, Alloc>::init_type = std::pair<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>]’
2024-03-31T14:31:31.2717967Z ../deps/v8/src/compiler/turboshaft/pretenuring-propagation-reducer.h:183:44:   required from here
2024-03-31T14:31:31.2722479Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/raw_hash_set.h:3335:56:   in ‘constexpr’ expansion of ‘absl::container_internal::hash_policy_traits<absl::container_internal::FlatHashMapPolicy<v8::internal::compiler::turboshaft::OpIndex, v8::internal::ZoneVector<v8::internal::compiler::turboshaft::OpIndex>*>, void>::get_hash_slot_fn<absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex> >()’
2024-03-31T14:31:31.2728380Z ../deps/v8/third_party/abseil-cpp/absl/container/internal/hash_policy_traits.h:163:54: error: ‘(absl::container_internal::TypeErasedApplyToSlotFn<absl::hash_internal::Hash<v8::internal::compiler::turboshaft::OpIndex>, v8::internal::compiler::turboshaft::OpIndex> == 0)’ is not a constant expression
2024-03-31T14:31:35.8286012Z make[2]: *** [tools/v8_gypfiles/v8_turboshaft.target.mk:224: /home/runner/work/node/node/out/Release/obj.target/v8_turboshaft/deps/v8/src/compiler/turboshaft/csa-optimize-phase.o] Error 1
2024-03-31T14:31:35.8287188Z make[2]: *** Waiting for unfinished jobs....
2024-03-31T14:32:17.7245954Z rm 9ac559b3661ef3e3ae7143f36ccc6691e578b31c.intermediate 2ad06b2c9baade6b27c5c82cdcc7af11c369378d.intermediate 02a486ff0aa87df511c38b125409357fdc559df2.intermediate
2024-03-31T14:32:17.7255924Z make[1]: *** [Makefile:134: node] Error 2
2024-03-31T14:32:17.7258403Z make: *** [Makefile:581: build-ci] Error 2
2024-03-31T14:32:17.7273528Z ##[error]Process completed with exit code 2.

@RafaelGSS
Copy link
Member

Can we include those files in the suppressions list?

@targos
Copy link
Member Author

targos commented Apr 1, 2024

Can you help me do it? I'm not familiar with ubsan and I don't know what to add to the suppressions list.

@StefanStojanovic
Copy link
Contributor

@StefanStojanovic b9d806a from the 12.2 update doesn't land cleanly (it has many conflicts).

As expected. I'll update the patch. Thanks for letting me know.

@targos
Copy link
Member Author

targos commented Apr 5, 2024

Can you help me do it? I'm not familiar with ubsan and I don't know what to add to the suppressions list.

I suspect it's unrelated to ubsan. I opened #52375 to use a more recent Ubuntu.

@targos
Copy link
Member Author

targos commented Apr 8, 2024

@RafaelGSS IIUC, it may be related to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962. I still don't really know what to do about it.
Latest V8 canary builds include #52375 and fail with the same error.

@RafaelGSS
Copy link
Member

@RafaelGSS IIUC, it may be related to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962. I still don't really know what to do about it. Latest V8 canary builds include #52375 and fail with the same error.

I will take a look as soon as I finish the security release

@targos
Copy link
Member Author

targos commented Apr 10, 2024

@StefanStojanovic do you have an ETA for the Windows fix? v22.0.0 is dangerously close.

@nodejs-github-bot
Copy link
Collaborator

@StefanStojanovic
Copy link
Contributor

@StefanStojanovic do you have an ETA for the Windows fix? v22.0.0 is dangerously close.

@targos I was able to get it to compile yesterday. I am still not sure if I broke something in the process and will need to run tests. Also, I'm trying to see if I can decrease the number of changes from the last time (I was already able to drop some). When will the v22 be locked for the official RC?

@targos
Copy link
Member Author

targos commented Apr 11, 2024

When will the v22 be locked for the official RC?

I don't know but I suppose some day next week. I was hoping to also try and update to 12.4 before it, that's why I'm a bit scared of timing.

@targos
Copy link
Member Author

targos commented Apr 11, 2024

Actually, I'll open a parallel PR for 12.4 right away. If the only issue is the Windows patch, we may skip this one.

@StefanStojanovic
Copy link
Contributor

That sounds good, I decreased the number of files affected by the patch, so now there is at least some chance, although a small one if I'm being honest, to simply apply v12.3 patch on v12.4.

@targos targos mentioned this pull request Apr 11, 2024
@targos
Copy link
Member Author

targos commented Apr 11, 2024

12.4 PR: #52465

@StefanStojanovic
Copy link
Contributor

@targos here is how things stand with this. I have a branch (will tidy it up once I am about to open a PR). I ran it through CI. Here is the list of the runs (each was a Resume build from the previous):

In the first two builds I had some tests fail. They were behaving like flaky tests as they failed in only one configuration in each build, but passed in all others. The test that failed in both is test-error-serdes, which I didn't see flaking before.

On another note I tried applying patches on v12.4 and saw only 3-4 files had issues. So it should not be too hard to try and apply it on v12.4, although I cannot guarantee it will compile without further changes. I'll work on that tomorrow and update you on the other PR with what I've got.

nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jun 29, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jun 30, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Jun 30, 2024
PR-URL: #52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit to targos/node that referenced this pull request Jun 30, 2024
PR-URL: nodejs#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 1, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 2, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 3, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 4, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 5, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 6, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 7, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 8, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 9, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 10, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 11, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 12, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 13, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 14, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 15, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 16, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit to targos/node that referenced this pull request Jul 17, 2024
PR-URL: nodejs#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit to targos/node that referenced this pull request Jul 17, 2024
PR-URL: nodejs#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Jul 28, 2024
PR-URL: #52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit to targos/node that referenced this pull request Jul 28, 2024
PR-URL: nodejs#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 28, 2024
PR-URL: nodejs/node#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit to targos/node that referenced this pull request Jul 28, 2024
PR-URL: nodejs#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit to targos/node that referenced this pull request Aug 7, 2024
PR-URL: nodejs#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit to targos/node that referenced this pull request Aug 9, 2024
PR-URL: nodejs#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit to targos/node that referenced this pull request Aug 14, 2024
PR-URL: nodejs#52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
targos added a commit that referenced this pull request Aug 16, 2024
PR-URL: #52293
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants