doc: add lint-js-fix into BUILDING.md #52290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is any auto-fixable linting errors, there is not a way to pass `--fix` into `make lint-js` as far as I am aware of. Spent quiet some time fixing them one by one and just realised `lint-js-fix` exists.
nodejs-github-bot
added
build
lpinca
approved these changes
Mar 31, 2024
MoLow
approved these changes
Mar 31, 2024
aymen94
approved these changes
Apr 2, 2024
anonrig
approved these changes
Apr 10, 2024
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d32a914 |
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
When there is any auto-fixable linting errors, there is not a way to pass `--fix` into `make lint-js` as far as I am aware of. Spent quiet some time fixing them one by one and just realised `lint-js-fix` exists. PR-URL: #52290 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
When there is any auto-fixable linting errors, there is not a way to pass `--fix` into `make lint-js` as far as I am aware of. Spent quiet some time fixing them one by one and just realised `lint-js-fix` exists. PR-URL: #52290 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there isn't a way to pass
--fixintomake lint-jsas far as I am aware of. Spent quiet some time fixing them one by one and just realisedlint-js-fixexists.Tried node-code-ide-configs and thought this will provide some sort of format on save but didn't make it work. Feels a bit painful to deal with small things like this when making a contribution. Happy to be educated a better way to deal / fix with lint errors.