Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update undici to 6.10.2 #52175

Closed
wants to merge 3 commits into from

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Mar 21, 2024

This is an automated update of undici to 6.10.2.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Mar 21, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 21, 2024
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

cc @nodejs/undici

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@mcollina
Copy link
Member

Could we fast track?

@mcollina mcollina added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 21, 2024
Copy link
Contributor

Fast-track has been requested by @mcollina. Please 👍 to approve.

@targos
Copy link
Member

targos commented Mar 21, 2024

We don't need to. There's no release scheduled this week

@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@mcollina mcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Mar 24, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 24, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@richardlau
Copy link
Member

Looks like this is breaking the withoutintl builds.

@@ -226,7 +248,7 @@ await fetch('https://example.com', { body: data, method: 'POST', duplex: 'half'

- half

In this implementation of fetch, `request.duplex` must be set if `request.body` is `ReadableStream` or `Async Iterables`. And fetch requests are currently always be full duplex. More detail refer to [Fetch Standard.](https://fetch.spec.whatwg.org/#dom-requestinit-duplex)
In this implementation of fetch, `request.duplex` must be set if `request.body` is `ReadableStream` or `Async Iterables`, however, fetch requests are currently always full duplex. For more detail refer to the [Fetch Standard.](https://fetch.spec.whatwg.org/#dom-requestinit-duplex).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just reading a bit the changes of this PR, and just saw this:

Suggested change
In this implementation of fetch, `request.duplex` must be set if `request.body` is `ReadableStream` or `Async Iterables`, however, fetch requests are currently always full duplex. For more detail refer to the [Fetch Standard.](https://fetch.spec.whatwg.org/#dom-requestinit-duplex).
In this implementation of fetch, `request.duplex` must be set if `request.body` is `ReadableStream` or `Async Iterables`, however, fetch requests are currently always full duplex. For more details, refer to the [Fetch Standard](https://fetch.spec.whatwg.org/#dom-requestinit-duplex).

@nodejs-github-bot nodejs-github-bot changed the title deps: update undici to 6.10.1 deps: update undici to 6.10.2 Mar 27, 2024
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 27, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@panva panva closed this Mar 27, 2024
@panva panva deleted the actions/tools-update-undici branch March 27, 2024 09:53
@panva
Copy link
Member

panva commented Mar 27, 2024

#52227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.