lib: emit listening event once when call listen twice #52119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
ShogunPanda
approved these changes
Mar 18, 2024
github-actions
bot
removed
the
request-ci
theanarkh
force-pushed
the
fix_call_net_listen_twice
branch
from
ae3fc20 to
dae3f7e
Compare
theanarkh
force-pushed
the
fix_call_net_listen_twice
branch
from
dae3f7e to
db908c7
Compare
github-actions
bot
removed
the
request-ci
mcollina
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/52119 ✔ Done loading data for nodejs/node/pull/52119 ----------------------------------- PR info ------------------------------------ Title lib: emit listening event once when call listen twice (#52119) Author theanarkh (@theanarkh) Branch theanarkh:fix_call_net_listen_twice -> nodejs:main Labels net, author ready Commits 1 - lib: emit listening event once when call listen twice Committers 1 - theanarkh PR-URL: https://github.com/nodejs/node/pull/52119 Reviewed-By: Paolo Insogna Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52119 Reviewed-By: Paolo Insogna Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - lib: emit listening event once when call listen twice ℹ This PR was created on Sat, 16 Mar 2024 18:40:00 GMT ✔ Approvals: 2 ✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/52119#pullrequestreview-1942044076 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/52119#pullrequestreview-1942412097 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-03-19T11:23:20Z: https://ci.nodejs.org/job/node-test-pull-request/57835/ - Querying data for job/node-test-pull-request/57835/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8345768283 |
mcollina
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 14de082 |
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
PR-URL: nodejs#52119 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52119 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52119 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we can call listen twice with same server in cluster worker. It will make some issues.
listeningevent twice(See lib: make sure clear the old timer in http server #52118).make -j4 test(UNIX), orvcbuild test(Windows) passes