doc: add some commonly used labels up front #52006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the last onboarding session I think it would be good to add two commonly used lables to the section which is linked from the onboarding doc. Signed-off-by: Michael Dawson <midawson@redhat.com>
|
Review requested:
|
targos
reviewed
Mar 7, 2024
MoLow
reviewed
Mar 7, 2024
| @@ -879,9 +879,13 @@ If you cannot find who to cc for a file, `git shortlog -n -s <file>` can help. | |||
|
|
|||
| * `confirmed-bug`: Bugs you have verified | |||
| * `discuss`: Things that need larger discussion | |||
| * `fast-track`: PRs that need to land faster - see | |||
There was a problem hiding this comment.
I wonder if putting
fast-track
https://github.com/nodejs/node/labels/fast-track) into the markdown will automatically get the color
There was a problem hiding this comment.
@MoLow are we getting the color or the others but not for these?
sxa
changed the title
sxa
changed the title
Co-authored-by: Michaël Zasso <targos@protonmail.com>
benjamingr
approved these changes
Mar 8, 2024
benjamingr
approved these changes
Mar 8, 2024
lpinca
approved these changes
Mar 8, 2024
RafaelGSS
approved these changes
Mar 8, 2024
trivikr
approved these changes
Mar 9, 2024
marco-ippolito
approved these changes
Mar 9, 2024
ShogunPanda
approved these changes
Mar 9, 2024
aduh95
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in e11c1d2 |
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
From the last onboarding session I think it would be good to add two commonly used lables to the section which is linked from the onboarding doc. Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: nodejs#52006 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
From the last onboarding session I think it would be good to add two commonly used lables to the section which is linked from the onboarding doc. Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #52006 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Merged
jcbhmr
pushed a commit
to jcbhmr/node
that referenced
this pull request
May 15, 2024
From the last onboarding session I think it would be good to add two commonly used lables to the section which is linked from the onboarding doc. Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: nodejs#52006 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the last onboarding session I think it would be good to add two commonly used lables to the section which is linked from the onboarding doc.