Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add stability index to crypto.hash() #51978

Merged
merged 1 commit into from
Mar 5, 2024
Merged

doc: add stability index to crypto.hash() #51978

merged 1 commit into from
Mar 5, 2024

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 5, 2024
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Fast-track has been requested by @joyeecheung. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Mar 5, 2024
@joyeecheung
Copy link
Member Author

Sorry, this is a bit last-minute. @nodejs/releasers Can we fast-track this before the API is released to v21.7.0?

Also cc @panva @tniessen

@RafaelGSS
Copy link
Member

@joyeecheung We'll include it.

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 5, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 5, 2024
@nodejs-github-bot nodejs-github-bot merged commit d96606d into nodejs:main Mar 5, 2024
25 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d96606d

marco-ippolito pushed a commit that referenced this pull request Mar 5, 2024
@joyeecheung @marco-ippolito
doc: add stability index to crypto.hash()
4a889e8 
PR-URL: #51978
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 5, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@joyeecheung @richardlau
doc: add stability index to crypto.hash()
ce655b5 
PR-URL: #51978
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@joyeecheung @richardlau
doc: add stability index to crypto.hash()
276d1d1 
PR-URL: #51978
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@joyeecheung @rdw-msft
doc: add stability index to crypto.hash()
c238d89 
PR-URL: nodejs#51978
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

@lpinca lpinca lpinca approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joyeecheung @nodejs-github-bot @RafaelGSS @panva @lpinca @marco-ippolito