Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_runner: add test:complete event to reflect execution order #51909

Merged
merged 2 commits into from
Mar 1, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions doc/api/test.md
Original file line number Diff line number Diff line change
Expand Up @@ -2438,6 +2438,9 @@ A successful call to [`run()`][] method will return a new {TestsStream}
object, streaming a series of events representing the execution of the tests.
`TestsStream` will emit events, in the order of the tests definition

some of the events are guaranteed to be emitted in the same order as the tests
MoLow marked this conversation as resolved.
Show resolved Hide resolved
are defined, while others are emitted in the order of the tests execution.
MoLow marked this conversation as resolved.
Show resolved Hide resolved

### Event: `'test:coverage'`

* `data` {Object}
Expand Down Expand Up @@ -2484,6 +2487,34 @@ object, streaming a series of events representing the execution of the tests.

Emitted when code coverage is enabled and all tests have completed.

### Event: `'test:complete'`

* `data` {Object}
* `column` {number|undefined} The column number where the test is defined, or
`undefined` if the test was run through the REPL.
* `details` {Object} Additional execution metadata.
* `passed` {boolean} Whether the test passed or not.
* `duration_ms` {number} The duration of the test in milliseconds.
* `error` {Error|undefined} An error wrapping the error thrown by the test
if it did not pass.
* `cause` {Error} The actual error thrown by the test.
* `type` {string|undefined} The type of the test, used to denote whether
this is a suite.
* `file` {string|undefined} The path of the test file,
`undefined` if test was run through the REPL.
* `line` {number|undefined} The line number where the test is defined, or
`undefined` if the test was run through the REPL.
* `name` {string} The test name.
* `nesting` {number} The nesting level of the test.
* `testNumber` {number} The ordinal number of the test.
* `todo` {string|boolean|undefined} Present if [`context.todo`][] is called
* `skip` {string|boolean|undefined} Present if [`context.skip`][] is called

Emitted when a test completes its execution.
This event is not emitted in the same order as the tests are
defined.
the corresponding declaration ordered events are `test:pass` and `test:fail`.
MoLow marked this conversation as resolved.
Show resolved Hide resolved

### Event: `'test:dequeue'`

* `data` {Object}
Expand All @@ -2497,6 +2528,8 @@ Emitted when code coverage is enabled and all tests have completed.
* `nesting` {number} The nesting level of the test.

Emitted when a test is dequeued, right before it is executed.
This event is not guaranteed to be emitted in the same order as the tests are
defined. the corresponding declaration ordered event is `test:start`.
MoLow marked this conversation as resolved.
Show resolved Hide resolved

### Event: `'test:diagnostic'`

Expand All @@ -2511,6 +2544,8 @@ Emitted when a test is dequeued, right before it is executed.
* `nesting` {number} The nesting level of the test.

Emitted when [`context.diagnostic`][] is called.
This event is guaranteed to be emitted in the same order as the tests are
defined.

### Event: `'test:enqueue'`

Expand Down Expand Up @@ -2548,6 +2583,9 @@ Emitted when a test is enqueued for execution.
* `skip` {string|boolean|undefined} Present if [`context.skip`][] is called

Emitted when a test fails.
This event is guaranteed to be emitted in the same order as the tests are
defined.
the corresponding exectuion ordered event is `test:complete`.
MoLow marked this conversation as resolved.
Show resolved Hide resolved

### Event: `'test:pass'`

Expand All @@ -2569,6 +2607,9 @@ Emitted when a test fails.
* `skip` {string|boolean|undefined} Present if [`context.skip`][] is called

Emitted when a test passes.
This event is guaranteed to be emitted in the same order as the tests are
defined.
the corresponding exectuion ordered event is `test:complete`.
MoLow marked this conversation as resolved.
Show resolved Hide resolved

### Event: `'test:plan'`

Expand All @@ -2583,6 +2624,8 @@ Emitted when a test passes.
* `count` {number} The number of subtests that have ran.

Emitted when all subtests have completed for a given test.
This event is guaranteed to be emitted in the same order as the tests are
defined.

### Event: `'test:start'`

Expand All @@ -2599,6 +2642,7 @@ Emitted when all subtests have completed for a given test.
Emitted when a test starts reporting its own and its subtests status.
This event is guaranteed to be emitted in the same order as the tests are
defined.
the corresponding exectuion ordered event is `test:dequeue`.
MoLow marked this conversation as resolved.
Show resolved Hide resolved

### Event: `'test:stderr'`

Expand All @@ -2612,6 +2656,8 @@ defined.

Emitted when a running test writes to `stderr`.
This event is only emitted if `--test` flag is passed.
This event is not guaranteed to be emitted in the same order as the tests are
defined.

### Event: `'test:stdout'`

Expand All @@ -2625,6 +2671,8 @@ This event is only emitted if `--test` flag is passed.

Emitted when a running test writes to `stdout`.
This event is only emitted if `--test` flag is passed.
This event is not guaranteed to be emitted in the same order as the tests are
defined.

### Event: `'test:watch:drained'`

Expand Down
31 changes: 21 additions & 10 deletions lib/internal/test_runner/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -726,6 +726,10 @@ class Test extends AsyncResource {
this.mock?.reset();

if (this.parent !== null) {
const report = this.#getReportDetails();
report.details.passed = this.passed;
this.reporter.complete(this.nesting, this.loc, this.testNumber, this.name, report.details, report.directive);

this.parent.activeSubtests--;
this.parent.addReadySubtest(this);
this.parent.processReadySubtestRange(false);
Expand Down Expand Up @@ -806,13 +810,7 @@ class Test extends AsyncResource {
return Number(this.endTime - this.startTime) / 1_000_000;
}

report() {
countCompletedTest(this);
if (this.subtests.length > 0) {
this.reporter.plan(this.subtests[0].nesting, this.loc, this.subtests.length);
} else {
this.reportStarted();
}
#getReportDetails() {
MoLow marked this conversation as resolved.
Show resolved Hide resolved
let directive;
const details = { __proto__: null, duration_ms: this.duration() };

Expand All @@ -825,12 +823,25 @@ class Test extends AsyncResource {
if (this.reportedType) {
details.type = this.reportedType;
}
if (!this.passed) {
details.error = this.error;
}
return { __proto__: null, details, directive };
}

report() {
countCompletedTest(this);
if (this.subtests.length > 0) {
this.reporter.plan(this.subtests[0].nesting, this.loc, this.subtests.length);
} else {
this.reportStarted();
}
const report = this.#getReportDetails();

if (this.passed) {
this.reporter.ok(this.nesting, this.loc, this.testNumber, this.name, details, directive);
this.reporter.ok(this.nesting, this.loc, this.testNumber, this.name, report.details, report.directive);
} else {
details.error = this.error;
this.reporter.fail(this.nesting, this.loc, this.testNumber, this.name, details, directive);
this.reporter.fail(this.nesting, this.loc, this.testNumber, this.name, report.details, report.directive);
}

for (let i = 0; i < this.diagnostics.length; i++) {
Expand Down
12 changes: 12 additions & 0 deletions lib/internal/test_runner/tests_stream.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,18 @@ class TestsStream extends Readable {
});
}

complete(nesting, loc, testNumber, name, details, directive) {
this[kEmitMessage]('test:complete', {
__proto__: null,
name,
nesting,
testNumber,
details,
...loc,
...directive,
});
}

plan(nesting, loc, count) {
this[kEmitMessage]('test:plan', {
__proto__: null,
Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-runner-reporters.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ describe('node:test reporters', { concurrency: true }, () => {
testFile]);
assert.strictEqual(child.stderr.toString(), '');
const stdout = child.stdout.toString();
assert.match(stdout, /{"test:enqueue":5,"test:dequeue":5,"test:start":4,"test:pass":2,"test:fail":2,"test:plan":2,"test:diagnostic":\d+}$/);
assert.match(stdout, /{"test:enqueue":5,"test:dequeue":5,"test:complete":5,"test:start":4,"test:pass":2,"test:fail":2,"test:plan":2,"test:diagnostic":\d+}$/);
assert.strictEqual(stdout.slice(0, filename.length + 2), `${filename} {`);
});
});
Expand All @@ -108,7 +108,7 @@ describe('node:test reporters', { concurrency: true }, () => {
assert.strictEqual(child.stderr.toString(), '');
assert.match(
child.stdout.toString(),
/^package: reporter-cjs{"test:enqueue":5,"test:dequeue":5,"test:start":4,"test:pass":2,"test:fail":2,"test:plan":2,"test:diagnostic":\d+}$/,
/^package: reporter-cjs{"test:enqueue":5,"test:dequeue":5,"test:complete":5,"test:start":4,"test:pass":2,"test:fail":2,"test:plan":2,"test:diagnostic":\d+}$/,
);
});

Expand All @@ -119,7 +119,7 @@ describe('node:test reporters', { concurrency: true }, () => {
assert.strictEqual(child.stderr.toString(), '');
assert.match(
child.stdout.toString(),
/^package: reporter-esm{"test:enqueue":5,"test:dequeue":5,"test:start":4,"test:pass":2,"test:fail":2,"test:plan":2,"test:diagnostic":\d+}$/,
/^package: reporter-esm{"test:enqueue":5,"test:dequeue":5,"test:complete":5,"test:start":4,"test:pass":2,"test:fail":2,"test:plan":2,"test:diagnostic":\d+}$/,
);
});

Expand Down
Loading