Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix unreliable assumption in js-native-api/test_cannot_run_js #51898

Merged
merged 3 commits into from
Mar 1, 2024

Commits on Feb 27, 2024

  1. test: fix unreliable assumption in js-native-api/test_cannot_run_js

    Previously the test assumes that when the queued finalizer is run,
    it must be run at a point where env->can_call_into_js() is false
    (typically, during Environment shutdown), which is not certain.
    If GC kicks in early and the second pass finalizer is queued before
    the event loop runs the check callbacks, the finalizer would then
    be called in check callbacks (via native immediates), where
    the finalizer can still call into JS. Essentially, addons can't
    make assumptions about where the queued finalizer would be called.
    This patch updates the assertions in the test to account for that.
    joyeecheung committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    4165dca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e69bbce View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Configuration menu
    Copy the full SHA
    d78f663 View commit details
    Browse the repository at this point in the history