Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: add stack on unhandled rejections #51751

Closed
wants to merge 1 commit into from
Closed

test_runner: add stack on unhandled rejections #51751

wants to merge 1 commit into from

Conversation

atlowChemi
Copy link
Member

Fixes: #51714

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 13, 2024 •
edited by rluvaton
Loading

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Feb 13, 2024
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 14, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 14, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57078/

@atlowChemi atlowChemi force-pushed the test-runner-handler-add-stack branch from 759b0a2 to 3ee0d83 Compare March 12, 2024 18:50
@atlowChemi atlowChemi force-pushed the test-runner-handler-add-stack branch from 3ee0d83 to 1681786 Compare April 16, 2024 15:25
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 16, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 16, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58440/

@cjihrig cjihrig mentioned this pull request May 6, 2024
Closed
@cjihrig
Copy link
Contributor

cjihrig commented Aug 13, 2024

@atlowChemi are you still planning to work on this? If not, can we close it out?

@atlowChemi
Copy link
Member Author

@atlowChemi are you still planning to work on this? If not, can we close it out?

@cjihrig I was unable to figure out the issue with the stack trace on windows, and I don't currently have the time to investigate this, so I don't think I'll be looking at it anytime soon...

@atlowChemi atlowChemi closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@aduh95 aduh95 aduh95 approved these changes

@MoLow MoLow MoLow approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Async errors are blocked until test run is finished
9 participants
@atlowChemi @nodejs-github-bot @cjihrig @benjamingr @lpinca @MoLow @aduh95 @marco-ippolito @mertcanaltin