Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove test-cli-node-options flaky designation #51716

Merged
merged 1 commit into from
Feb 17, 2024
Merged

test: remove test-cli-node-options flaky designation #51716

merged 1 commit into from
Feb 17, 2024

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Feb 10, 2024

The last trace of failure dates back to 2023-09-24.

Fixes: #50295

@lpinca
test: remove test-cli-node-options flaky designation
a6effb6 
The last trace of failure dates back to 2023-09-24.

Fixes: nodejs#50295
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 10, 2024
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57096/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57103/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57129/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57133/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57141/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57151/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 17, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 17, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6db72fc into nodejs:main Feb 17, 2024
61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6db72fc

@lpinca lpinca deleted the remove/flaky-test-cli-node-options branch February 17, 2024 17:02
targos pushed a commit that referenced this pull request Feb 19, 2024
@lpinca @targos
test: remove test-cli-node-options flaky designation
ea08350 
The last trace of failure dates back to 2023-09-24.

Fixes: #50295
PR-URL: #51716
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 20, 2024
@lpinca @rdw-msft
test: remove test-cli-node-options flaky designation
3bcf659 
The last trace of failure dates back to 2023-09-24.

Fixes: nodejs#50295
PR-URL: nodejs#51716
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@lpinca @richardlau
test: remove test-cli-node-options flaky designation
8236716 
The last trace of failure dates back to 2023-09-24.

Fixes: #50295
PR-URL: #51716
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@lpinca @richardlau
test: remove test-cli-node-options flaky designation
c33f860 
The last trace of failure dates back to 2023-09-24.

Fixes: #50295
PR-URL: #51716
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parallel.test-cli-node-options is flaky
4 participants
@lpinca @nodejs-github-bot @benjamingr @targos