-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v21.6.1 proposal #51530
Merged
Merged
v21.6.1 proposal #51530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4d3923a. PR-URL: #51491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #51491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
nodejs-github-bot
added
meta
Issues and PRs related to the general management of the project.
needs-ci
PRs that need a full CI run.
v21.x
web streams
labels
Jan 19, 2024
RafaelGSS
added a commit
that referenced
this pull request
Jan 19, 2024
Notable changes: This release fixes a bug in `undici` using WebStreams PR-URL: #51530
RafaelGSS
force-pushed
the
v21.6.1-proposal
branch
from
January 19, 2024 19:11
254b8cd
to
7f9a864
Compare
RafaelGSS
added
release
Issues and PRs related to Node.js releases.
and removed
meta
Issues and PRs related to the general management of the project.
web streams
labels
Jan 19, 2024
anonrig
requested changes
Jan 19, 2024
mcollina
approved these changes
Jan 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Notable changes: This release fixes a bug in `undici` using WebStreams PR-URL: #51530
RafaelGSS
force-pushed
the
v21.6.1-proposal
branch
from
January 20, 2024 13:02
7f9a864
to
3dc0e49
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jan 20, 2024
@anonrig can you dismiss the review? |
anonrig
approved these changes
Jan 21, 2024
FWIW Release is blocked because we are facing a problem with macOS binaries. |
RafaelGSS
added a commit
that referenced
this pull request
Jan 22, 2024
Notable changes: This release fixes a bug in `undici` using WebStreams PR-URL: #51530
RafaelGSS
added a commit
to RafaelGSS/nodejs.org
that referenced
this pull request
Jan 22, 2024
github-merge-queue bot
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Jan 22, 2024
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Feb 2, 2024
Notable changes: This release fixes a bug in `undici` using WebStreams PR-URL: nodejs#51530
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Feb 19, 2024
Notable changes: This release fixes a bug in `undici` using WebStreams PR-URL: nodejs#51530
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024-01-22, Version 21.6.1 (Current), @RafaelGSS
Notable Changes
This release fixes a bug in
undici
using WebStreamsCommits
662ac95729
] - Revert "stream: fix cloned webstreams not being unref'd" (Matteo Collina) #514911b8bba8aee
] - test: add regression test for 51586 (Matteo Collina) #51491