Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v21.6.1 proposal #51530

Merged
merged 3 commits into from
Jan 22, 2024
Merged

v21.6.1 proposal #51530

merged 3 commits into from
Jan 22, 2024

Conversation

RafaelGSS
Copy link
Member

2024-01-22, Version 21.6.1 (Current), @RafaelGSS

Notable Changes

This release fixes a bug in undici using WebStreams

Commits

  • [662ac95729] - Revert "stream: fix cloned webstreams not being unref'd" (Matteo Collina) #51491
  • [1b8bba8aee] - test: add regression test for 51586 (Matteo Collina) #51491

This reverts commit 4d3923a.

PR-URL: #51491
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #51491
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v21.x web streams labels Jan 19, 2024
RafaelGSS added a commit that referenced this pull request Jan 19, 2024
Notable changes:

This release fixes a bug in `undici` using WebStreams

PR-URL: #51530
@RafaelGSS
Copy link
Member Author

RafaelGSS commented Jan 19, 2024

Considering I won't release it until Monday 22/01/2024 if #51526 gets landed on this, I can include it in this patch.

cc: @mcollina

@RafaelGSS RafaelGSS added release Issues and PRs related to Node.js releases. and removed meta Issues and PRs related to the general management of the project. web streams labels Jan 19, 2024
t.mjs Outdated Show resolved Hide resolved
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2024
Notable changes:

This release fixes a bug in `undici` using WebStreams

PR-URL: #51530
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 20, 2024

@RafaelGSS
Copy link
Member Author

@anonrig can you dismiss the review?

@RafaelGSS
Copy link
Member Author

FWIW Release is blocked because we are facing a problem with macOS binaries.

RafaelGSS added a commit that referenced this pull request Jan 22, 2024
@RafaelGSS RafaelGSS merged commit 3dc0e49 into v21.x Jan 22, 2024
48 checks passed
@RafaelGSS RafaelGSS deleted the v21.6.1-proposal branch January 22, 2024 19:16
RafaelGSS added a commit that referenced this pull request Jan 22, 2024
Notable changes:

This release fixes a bug in `undici` using WebStreams

PR-URL: #51530
RafaelGSS added a commit to RafaelGSS/nodejs.org that referenced this pull request Jan 22, 2024
github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request Jan 22, 2024
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 2, 2024
Notable changes:

This release fixes a bug in `undici` using WebStreams

PR-URL: nodejs#51530
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 19, 2024
Notable changes:

This release fixes a bug in `undici` using WebStreams

PR-URL: nodejs#51530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants