doc: add links in offboarding.md
#51440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
H4ad
approved these changes
Jan 12, 2024
|
Do you have any reason/follow-up to link to this change? I mean, they make sense but just for historical reasons. If not, is not a problem. |
richardlau
approved these changes
Jan 12, 2024
I don't know about historical reasons, the reason I'm suggesting adding those is for practical reasons, and because the time of volunteers who take care of offboarding folks is precious. |
UlisesGascon
approved these changes
Jan 12, 2024
aymen94
approved these changes
Jan 12, 2024
marco-ippolito
approved these changes
Jan 12, 2024
aduh95
added
author ready
benjamingr
approved these changes
Jan 12, 2024
lpinca
approved these changes
Jan 12, 2024
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/51440 ✔ Done loading data for nodejs/node/pull/51440 ----------------------------------- PR info ------------------------------------ Title doc: add links in `offboarding.md` (#51440) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:offboard-links -> nodejs:main Labels doc, author ready Commits 2 - doc: add links in `offboarding.md` - EOL EOF Committers 2 - Antoine du Hamel - GitHub PR-URL: https://github.com/nodejs/node/pull/51440 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Richard Lau Reviewed-By: Marco Ippolito Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Michael Dawson ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51440 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Richard Lau Reviewed-By: Marco Ippolito Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Michael Dawson -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 12 Jan 2024 09:19:20 GMT ✔ Approvals: 6 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/51440#pullrequestreview-1818128038 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/51440#pullrequestreview-1818197414 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/51440#pullrequestreview-1818687521 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/51440#pullrequestreview-1818714984 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51440#pullrequestreview-1818941152 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/51440#pullrequestreview-1819163113 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51440 From https://github.com/nodejs/node * branch refs/pull/51440/merge -> FETCH_HEAD ✔ Fetched commits as c25878d370c6..d23605cf26bf -------------------------------------------------------------------------------- [main 2a49384c0f] doc: add links in `offboarding.md` Author: Antoine du Hamel Date: Fri Jan 12 10:11:11 2024 +0100 1 file changed, 9 insertions(+), 4 deletions(-) [main e77e6cbefc] EOL EOF Author: Antoine du Hamel Date: Fri Jan 12 15:30:07 2024 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/7518258776 |
nodejs-github-bot
added
the
commit-queue-failed
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9fce1df |
Medhansh404
pushed a commit
to Medhansh404/node
that referenced
this pull request
Jan 19, 2024
PR-URL: nodejs#51440 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
PR-URL: #51440 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51440 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51440 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.