New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: disable gh-5100 test when in FIPS mode #5144

Closed

indutny wants to merge 1 commit into nodejs:master from indutny:fixup/for-5100

Member

indutny commented Feb 8, 2016

This is a follow-up fix for half-broken test in 23196fe, and an attempt
to recover some dignity after breaking CI.


          test: disable nodejsgh-5100 test when in FIPS mode

829764e

This is a follow-up fix for half-broken test in 23196fe, and an attempt
to recover some dignity after breaking CI.

Member Author

indutny commented Feb 8, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/1591/

Member

Trott commented Feb 8, 2016

LGTM if CI is OK

Member Author

indutny commented Feb 8, 2016

@Trott I'm going to be off for a bit, so if you will notice that it is green earlier than I will do - feel free to land this. Thanks!

mscdex added test tls labels

Trott pushed a commit to Trott/io.js that referenced this pull request


          test: disable nodejsgh-5100 test when in FIPS mode

c64d051

This is a follow-up fix for half-broken test in 23196fe, and an attempt
to recover some dignity after breaking CI.

PR-URL: nodejs#5144
Reviewed-By: Rich Trott <rtrott@gmail.com>

Member

Trott commented Feb 8, 2016

Landed in c64d051

Trott closed this

indutny deleted the fixup/for-5100 branch

February 8, 2016 22:10

Contributor

shigeki commented Feb 9, 2016

It was my regrettable review to have missed to run CI and checked FIPS compliance.

The FIPS error comes from certificate is encrypted by RC2 and it can be resolved by the option of

-descert
           encrypt the certificate using triple DES, this may render the PKCS#12 file unreadable by some "export grade" software. By
           default the private key is encrypted using triple DES and the certificate using 40 bit RC2.

shigeki@4029465 and https://ci.nodejs.org/job/node-test-commit-linux-fips/869/ shows it works fine.

Member Author

indutny commented Feb 9, 2016

@shigeki great! Let's file a PR for this.

shigeki pushed a commit to shigeki/node that referenced this pull request


          test: enable to work pkcs12 test in FIPS mode

6abe80f

The pfx file created by pkcs12 command of openssl causes an error in
FIPS mode because its certificate is encrypted with RC2 by default.
Adding `-descert` option resolves the error.

Fix: nodejs#5144
Fix: nodejs#5109

shigeki mentioned this pull request

test: enable to work pkcs12 test in FIPS mode #5150

Closed

shigeki pushed a commit that referenced this pull request


          test: enable to work pkcs12 test in FIPS mode

dccccbb

The pfx file created by pkcs12 command of openssl causes an error in
FIPS mode because its certificate is encrypted with RC2 by default.
Adding `-descert` option resolves the error.

Fix: #5144
Fix: #5109
PR-URL: #5150
Reviewed-By: Rich Trott <rtrott@gmail.com>

rvagg pushed a commit that referenced this pull request


          test: disable gh-5100 test when in FIPS mode

4c2b7fb

This is a follow-up fix for half-broken test in 23196fe, and an attempt
to recover some dignity after breaking CI.

PR-URL: #5144
Reviewed-By: Rich Trott <rtrott@gmail.com>

rvagg pushed a commit that referenced this pull request


          test: enable to work pkcs12 test in FIPS mode

63e314a

The pfx file created by pkcs12 command of openssl causes an error in
FIPS mode because its certificate is encrypted with RC2 by default.
Adding `-descert` option resolves the error.

Fix: #5144
Fix: #5109
PR-URL: #5150
Reviewed-By: Rich Trott <rtrott@gmail.com>

rvagg pushed a commit that referenced this pull request


          test: disable gh-5100 test when in FIPS mode

e439066

This is a follow-up fix for half-broken test in 23196fe, and an attempt
to recover some dignity after breaking CI.

PR-URL: #5144
Reviewed-By: Rich Trott <rtrott@gmail.com>

rvagg pushed a commit that referenced this pull request


          test: enable to work pkcs12 test in FIPS mode

9dcc45e

The pfx file created by pkcs12 command of openssl causes an error in
FIPS mode because its certificate is encrypted with RC2 by default.
Adding `-descert` option resolves the error.

Fix: #5144
Fix: #5109
PR-URL: #5150
Reviewed-By: Rich Trott <rtrott@gmail.com>

jasnell added the lts-watch-v4.x label

MylesBorins pushed a commit that referenced this pull request


          test: disable gh-5100 test when in FIPS mode

9875e53

This is a follow-up fix for half-broken test in 23196fe, and an attempt
to recover some dignity after breaking CI.

PR-URL: #5144
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels

MylesBorins pushed a commit that referenced this pull request


          test: enable to work pkcs12 test in FIPS mode

0b63a85

The pfx file created by pkcs12 command of openssl causes an error in
FIPS mode because its certificate is encrypted with RC2 by default.
Adding `-descert` option resolves the error.

Fix: #5144
Fix: #5109
PR-URL: #5150
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          test: disable gh-5100 test when in FIPS mode

6072d2e

This is a follow-up fix for half-broken test in 23196fe, and an attempt
to recover some dignity after breaking CI.

PR-URL: #5144
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          test: enable to work pkcs12 test in FIPS mode

46dc12b

The pfx file created by pkcs12 command of openssl causes an error in
FIPS mode because its certificate is encrypted with RC2 by default.
Adding `-descert` option resolves the error.

Fix: #5144
Fix: #5109
PR-URL: #5150
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins mentioned this pull request

V4.4.0 proposal #5301

Merged

MylesBorins pushed a commit that referenced this pull request


          test: disable gh-5100 test when in FIPS mode

0383d66

This is a follow-up fix for half-broken test in 23196fe, and an attempt
to recover some dignity after breaking CI.

PR-URL: #5144
Reviewed-By: Rich Trott <rtrott@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          test: enable to work pkcs12 test in FIPS mode

ed6d47b

The pfx file created by pkcs12 command of openssl causes an error in
FIPS mode because its certificate is encrypted with RC2 by default.
Adding `-descert` option resolves the error.

Fix: #5144
Fix: #5109
PR-URL: #5150
Reviewed-By: Rich Trott <rtrott@gmail.com>

scovetta pushed a commit to scovetta/node that referenced this pull request


          test: disable nodejsgh-5100 test when in FIPS mode

17bb17e

This is a follow-up fix for half-broken test in 23196fe, and an attempt
to recover some dignity after breaking CI.

PR-URL: nodejs#5144
Reviewed-By: Rich Trott <rtrott@gmail.com>

scovetta pushed a commit to scovetta/node that referenced this pull request


          test: enable to work pkcs12 test in FIPS mode

31f7f11

The pfx file created by pkcs12 command of openssl causes an error in
FIPS mode because its certificate is encrypted with RC2 by default.
Adding `-descert` option resolves the error.

Fix: nodejs#5144
Fix: nodejs#5109
PR-URL: nodejs#5150
Reviewed-By: Rich Trott <rtrott@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test tls