Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update inspector_protocol to 83b1154 #51309

Merged
merged 1 commit into from
Jan 11, 2024
Merged

tools: update inspector_protocol to 83b1154 #51309

merged 1 commit into from
Jan 11, 2024
+110 −166

Conversation

cola119
Copy link
Member

@cola119 cola119 commented Dec 29, 2023

New revision: 83b1154a9661d22bba9a368d368214cc20880419

This updates the usages of the protocol types to the new definitions, using std::vector-based implementations of protocol::Array.

This changes the usages of Array in Node inspector as following:

  • We can use array-style access vec[i]
  • We can use std::make_unique for creation
  • We can use emplace_back to insert elements

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 29, 2023
@cola119 cola119 added tools Issues and PRs related to the tools directory. inspector Issues and PRs related to the V8 inspector protocol request-ci Add this label to start a Jenkins CI on a PR. labels Dec 29, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 29, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@cola119 cola119 added the trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. label Dec 29, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56596/

@cola119
Copy link
Member Author

cola119 commented Jan 10, 2024

@nodejs/inspector @nodejs/v8-inspector

@eugeneo
Copy link
Contributor

eugeneo commented Jan 10, 2024

I would like to confirm that this is not hand-coded but came from the V8 repository. I do not remember the details, but it is preferred to minimize the divergence.

@eugeneo
Copy link
Contributor

eugeneo commented Jan 10, 2024

Oh, sorry, ignore my previous comment - noticed the link at the top. Approved, FWIW - I'm no longer a committer :)

@targos
Copy link
Member

targos commented Jan 10, 2024

@nodejs/cpp-reviewers

@cola119 cola119 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 11, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 11, 2024
@nodejs-github-bot nodejs-github-bot merged commit d102d16 into nodejs:main Jan 11, 2024
75 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d102d16

marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
@cola119 @marco-ippolito
tools: update inspector_protocol to 83b1154
c53146d 
PR-URL: nodejs#51309
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
@cola119 @Medhansh404
tools: update inspector_protocol to 83b1154
bca7bb2 
PR-URL: nodejs#51309
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
targos pushed a commit that referenced this pull request Feb 15, 2024
@cola119 @targos
tools: update inspector_protocol to 83b1154
f3845de 
PR-URL: #51309
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@cola119 @richardlau
tools: update inspector_protocol to 83b1154
c9bad3e 
PR-URL: #51309
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@cola119 @richardlau
tools: update inspector_protocol to 83b1154
6385c7a 
PR-URL: #51309
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qard Qard Qard approved these changes

@eugeneo eugeneo eugeneo approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cola119 @nodejs-github-bot @eugeneo @targos @Qard