Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update inspector_protocol to c488ba2 #51293

Closed
wants to merge 7 commits into from
Closed

Conversation

cola119
Copy link
Member

@cola119 cola119 commented Dec 27, 2023

Similar like #39694, this PR applied patches of inspector_protocol from ca525fc to c488ba2 to update our copies in tools/inspector_protocol. There should be no change in Node.js inspector code at this point.

There remain more commits ahead in the upstream that still need to be imported. I plan to address those in subsequent pull requests, and I wrote and used a simple script to import patches from the upstream, so I could incorporate it once it becomes adaptable to all cases.

Ref. https://chromium.googlesource.com/deps/inspector_protocol/+log

cc @nodejs/v8-inspector

@cola119 cola119 requested a review from Trott December 27, 2023 12:40
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 27, 2023
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 27, 2023
@cola119 cola119 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 28, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/51293
✔  Done loading data for nodejs/node/pull/51293
----------------------------------- PR info ------------------------------------
Title      tools: update inspector_protocol to c488ba2 (#51293)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     cola119:update-protocol-1 -> nodejs:main
Labels     tools, author ready
Commits    7
 - tools: update inspector_protocol to ca525fc
 - tools: update inspector_protocol to 547c5b8
 - tools: update inspector_protocol to 912eb68
 - tools: update inspector_protocol to d7b099b
 - tools: update inspector_protocol to 2f51e05
 - tools: update inspector_protocol to 9b4a4aa
 - tools: update inspector_protocol to c488ba2
Committers 1
 - cola119 
PR-URL: https://github.com/nodejs/node/pull/51293
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51293
Reviewed-By: Michaël Zasso 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 27 Dec 2023 12:40:29 GMT
   ✔  Approvals: 2
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/51293#pullrequestreview-1797217744
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51293#pullrequestreview-1797283641
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-12-27T16:17:16Z: https://ci.nodejs.org/job/node-test-pull-request/56555/
- Querying data for job/node-test-pull-request/56555/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 51293
From https://github.com/nodejs/node
 * branch                  refs/pull/51293/merge -> FETCH_HEAD
✔  Fetched commits as 9fe0424baa86..079db1869931
--------------------------------------------------------------------------------
[main a78dcb0f64] tools: update inspector_protocol to ca525fc
 Author: cola119 
 Date: Wed Dec 27 15:06:27 2023 +0900
 2 files changed, 2 insertions(+), 2 deletions(-)
[main 14e94b9bfa] tools: update inspector_protocol to 547c5b8
 Author: cola119 
 Date: Wed Dec 27 16:11:49 2023 +0900
 3 files changed, 28 insertions(+), 2 deletions(-)
[main 4626a1a47e] tools: update inspector_protocol to 912eb68
 Author: cola119 
 Date: Wed Dec 27 16:16:31 2023 +0900
 3 files changed, 82 insertions(+)
[main 2c44ebfa33] tools: update inspector_protocol to d7b099b
 Author: cola119 
 Date: Wed Dec 27 16:17:17 2023 +0900
 1 file changed, 3 insertions(+)
[main 311f707a35] tools: update inspector_protocol to 2f51e05
 Author: cola119 
 Date: Wed Dec 27 16:17:49 2023 +0900
 1 file changed, 7 insertions(+), 47 deletions(-)
[main 23a7d112cf] tools: update inspector_protocol to 9b4a4aa
 Author: cola119 
 Date: Wed Dec 27 16:18:17 2023 +0900
 1 file changed, 2 deletions(-)
[main cdd3292b7e] tools: update inspector_protocol to c488ba2
 Author: cola119 
 Date: Wed Dec 27 16:19:01 2023 +0900
 2 files changed, 31 insertions(+), 54 deletions(-)
   ✔  Patches applied
There are 7 commits in the PR. Attempting autorebase.
Rebasing (2/14)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: update inspector_protocol to ca525fc

PR-URL: #51293
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD 18b6886d54] tools: update inspector_protocol to ca525fc
Author: cola119 kohei.ueno119@gmail.com
Date: Wed Dec 27 15:06:27 2023 +0900
2 files changed, 2 insertions(+), 2 deletions(-)
Rebasing (3/14)
Rebasing (4/14)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: update inspector_protocol to 547c5b8

PR-URL: #51293
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD 191a5eab2a] tools: update inspector_protocol to 547c5b8
Author: cola119 kohei.ueno119@gmail.com
Date: Wed Dec 27 16:11:49 2023 +0900
3 files changed, 28 insertions(+), 2 deletions(-)
Rebasing (5/14)
Rebasing (6/14)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: update inspector_protocol to 912eb68

PR-URL: #51293
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD e21327847f] tools: update inspector_protocol to 912eb68
Author: cola119 kohei.ueno119@gmail.com
Date: Wed Dec 27 16:16:31 2023 +0900
3 files changed, 82 insertions(+)
Rebasing (7/14)
Rebasing (8/14)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: update inspector_protocol to d7b099b

PR-URL: #51293
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD 36d09e8095] tools: update inspector_protocol to d7b099b
Author: cola119 kohei.ueno119@gmail.com
Date: Wed Dec 27 16:17:17 2023 +0900
1 file changed, 3 insertions(+)
Rebasing (9/14)
Rebasing (10/14)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: update inspector_protocol to 2f51e05

PR-URL: #51293
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD 712330b153] tools: update inspector_protocol to 2f51e05
Author: cola119 kohei.ueno119@gmail.com
Date: Wed Dec 27 16:17:49 2023 +0900
1 file changed, 7 insertions(+), 47 deletions(-)
Rebasing (11/14)
Rebasing (12/14)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: update inspector_protocol to 9b4a4aa

PR-URL: #51293
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD 1916d46bba] tools: update inspector_protocol to 9b4a4aa
Author: cola119 kohei.ueno119@gmail.com
Date: Wed Dec 27 16:18:17 2023 +0900
1 file changed, 2 deletions(-)
Rebasing (13/14)
Rebasing (14/14)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: update inspector_protocol to c488ba2

PR-URL: #51293
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD 7a8d7073b0] tools: update inspector_protocol to c488ba2
Author: cola119 kohei.ueno119@gmail.com
Date: Wed Dec 27 16:19:01 2023 +0900
2 files changed, 31 insertions(+), 54 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/7356757303

@cola119 cola119 added commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 9fe0424...f6a83cd

nodejs-github-bot pushed a commit that referenced this pull request Dec 29, 2023
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Dec 29, 2023
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Dec 29, 2023
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Dec 29, 2023
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Dec 29, 2023
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Dec 29, 2023
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Dec 29, 2023
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos deleted the update-protocol-1 branch December 29, 2023 13:14
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51293
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants