-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated packages.md and added --experimental-detect-module flag #51089
Conversation
added --experimental-detect-module flag in the docs.
Review requested:
|
It feels wrong to duplicate what we have in |
@GeoffreyBooth I understand. But I did this after I asked here #51057 to fix the issue mentioned there. I'm new to github. My apology if any trouble caused. |
@shubherthi-mitra you didn’t do anything wrong, thank you for the contribution! My question was more for @nodejs/loaders, if we want to repeat the info here like you’ve done in this PR or if we’d rather do it differently, such as by just mentioning the flag’s existence and linking to its primary documentation. |
I think this (smaller surface area to update, less chance of divergence). |
I think what we want is to modify the paragraph added in https://github.com/nodejs/node/pull/50096/files#diff-71a7964a5c439435680952125e31e9dd4fca3a427982e6db86770fd0fbbfde63 to add a mention of the flag (and a link to |
Mentioned --experimental-detect-module flag and added its reference to cli.md
I did as you have said. Please check it. |
--experimental-detect-module flag and link to cli.md added.
Mentioned --experimental-defect-module flag in doc and added ref link to cli.md
Simplified the paragraph under the heading ###Determining module system, mentioning --experimental-detect-module flag and reference to cli.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Landed in 37ba7a3, thanks for the contribution 🎉 |
added --experimental-detect-module flag in the docs to resolve #51057
Fixes: #51057