Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: improve error performance of fs.writeSync #50923

Closed
wants to merge 1 commit into from
Closed

fs: improve error performance of fs.writeSync #50923

wants to merge 1 commit into from

Conversation

shubham9411
Copy link
Contributor

Benchmark on my system:

                                                                confidence improvement accuracy (*)   (**)  (***)
fs/bench-writeSync.js n=100000 dataType='buffer' type='invalid'        ***     81.88 %       ±1.24% ±1.66% ±2.19%
fs/bench-writeSync.js n=100000 dataType='buffer' type='valid'            *      1.49 %       ±1.38% ±1.85% ±2.43%
fs/bench-writeSync.js n=100000 dataType='string' type='invalid'        ***     81.60 %       ±2.34% ±3.15% ±4.16%
fs/bench-writeSync.js n=100000 dataType='string' type='valid'                   0.35 %       ±2.10% ±2.82% ±3.70%
fs/bench-writeFileSync.js n=10000                                              -0.12 %       ±3.45% ±4.59% ±5.98%

Ref: nodejs/performance#106

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 26, 2023
@anonrig anonrig mentioned this pull request Nov 26, 2023
Open
@anonrig anonrig added performance Issues and PRs related to the performance of Node.js. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 26, 2023
@pluris
Copy link
Contributor

pluris commented Nov 26, 2023 •
edited
Loading

Hello, Duplicated #50354

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 26, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55942/

@shubham9411
Copy link
Contributor Author

Hey @pluris, sorry it was not marked in Issue as working so I opened this PR. I'll close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shubham9411 @pluris @nodejs-github-bot @anonrig