Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix fs.writeFileSync return value documentation #50760

Merged
merged 1 commit into from
Nov 18, 2023
Merged

doc: fix fs.writeFileSync return value documentation #50760

merged 1 commit into from
Nov 18, 2023

Conversation

RyanZim
Copy link
Contributor

@RyanZim RyanZim commented Nov 16, 2023

In #50009, the return value was accidentally made part of flush option bullet point.

@RyanZim
doc: fix fs.writeFileSync return value documentation
81c4301 
In nodejs#50009, the return value was accidentally made part of `flush` option bullet point.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Nov 16, 2023
deokjinkim
deokjinkim approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@deokjinkim deokjinkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution :)

@deokjinkim deokjinkim added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 17, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 18, 2023
@nodejs-github-bot nodejs-github-bot merged commit 724a233 into nodejs:main Nov 18, 2023
26 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 724a233

@RyanZim RyanZim deleted the patch-1 branch November 20, 2023 20:25
targos pushed a commit that referenced this pull request Nov 23, 2023
@RyanZim @targos
doc: fix fs.writeFileSync return value documentation
d70454b 
In #50009, the return value was accidentally made part of `flush` option bullet point.

PR-URL: #50760
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@RyanZim @martenrichter
doc: fix fs.writeFileSync return value documentation
546bdbf 
In nodejs#50009, the return value was accidentally made part of `flush` option bullet point.

PR-URL: nodejs#50760
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@RyanZim
doc: fix fs.writeFileSync return value documentation
e83baa6 
In nodejs#50009, the return value was accidentally made part of `flush` option bullet point.

PR-URL: nodejs#50760
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@RyanZim @RafaelGSS
doc: fix fs.writeFileSync return value documentation
b4935dd 
In #50009, the return value was accidentally made part of `flush` option bullet point.

PR-URL: #50760
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@RyanZim @RafaelGSS
doc: fix fs.writeFileSync return value documentation
915b1ea 
In #50009, the return value was accidentally made part of `flush` option bullet point.

PR-URL: #50760
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@RyanZim @UlisesGascon
doc: fix fs.writeFileSync return value documentation
f89a5eb 
In #50009, the return value was accidentally made part of `flush` option bullet point.

PR-URL: #50760
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@RyanZim @UlisesGascon
doc: fix fs.writeFileSync return value documentation
549d442 
In #50009, the return value was accidentally made part of `flush` option bullet point.

PR-URL: #50760
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H4ad H4ad H4ad approved these changes

@deokjinkim deokjinkim deokjinkim approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RyanZim @nodejs-github-bot @lpinca @deokjinkim @H4ad