Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: WPT fixes for Compression Streams #50712

Closed
wants to merge 3 commits into from
Closed

stream: WPT fixes for Compression Streams #50712

wants to merge 3 commits into from

Conversation

panva
Copy link
Member

@panva panva commented Nov 13, 2023 •
edited
Loading

Followup to #50631

  • adds the expected Symbol.toStringTag to CompressionStream and DecompressionStream
  • yields the expected error (TypeError) on corrupt inputs
  • updates the idlharness test files and expectations overall

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Nov 13, 2023
@panva
Copy link
Member Author

panva commented Nov 13, 2023

cc @nodejs/streams

@panva panva added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Nov 13, 2023
@panva panva force-pushed the wpt-compression-fixes branch from eaf6907 to 00a38f5 Compare November 13, 2023 14:23
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
anonrig
anonrig reviewed Nov 13, 2023
View reviewed changes
lib/internal/webstreams/adapters.js Outdated Show resolved Hide resolved
lib/internal/webstreams/adapters.js Show resolved Hide resolved
lib/internal/webstreams/adapters.js Show resolved Hide resolved
@github-actions github-actions bot mentioned this pull request Nov 14, 2023
Open
25 tasks
@panva panva force-pushed the wpt-compression-fixes branch from f13ccd6 to 100f25c Compare November 14, 2023 08:45
@panva panva force-pushed the wpt-compression-fixes branch from 100f25c to 74d8ee5 Compare November 14, 2023 08:50
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55645/

@github-actions github-actions bot mentioned this pull request Nov 15, 2023
Open
26 tasks
@panva panva requested review from anonrig and ljharb November 18, 2023 12:25
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 18, 2023
mcollina
mcollina approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2023
nodejs-github-bot pushed a commit that referenced this pull request Nov 19, 2023
@panva @nodejs-github-bot
test: update WPT files for WebIDL tests
e0bbe8f 
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@panva panva deleted the wpt-compression-fixes branch November 19, 2023 07:37
targos pushed a commit that referenced this pull request Nov 23, 2023
@panva @targos
stream: add Symbol.toStringTag to Compression Streams
af9cd35 
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Nov 23, 2023
@panva @targos
stream: yield expected Error class on zlib errors
1f9065d 
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Nov 23, 2023
@panva @targos
test: update WPT files for WebIDL tests
b6c3cef 
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@panva @martenrichter
stream: add Symbol.toStringTag to Compression Streams
15c5b31 
PR-URL: nodejs#50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@panva @martenrichter
stream: yield expected Error class on zlib errors
8a2bc14 
PR-URL: nodejs#50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@panva @martenrichter
test: update WPT files for WebIDL tests
4154929 
PR-URL: nodejs#50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@panva
stream: add Symbol.toStringTag to Compression Streams
426ca12 
PR-URL: nodejs#50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@panva
stream: yield expected Error class on zlib errors
d899d5e 
PR-URL: nodejs#50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
@panva
test: update WPT files for WebIDL tests
cbdf5a6 
PR-URL: nodejs#50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@panva @RafaelGSS
stream: add Symbol.toStringTag to Compression Streams
a275155 
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@panva @RafaelGSS
stream: yield expected Error class on zlib errors
2e0abed 
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
@panva @RafaelGSS
test: update WPT files for WebIDL tests
f25637b 
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@panva @RafaelGSS
stream: add Symbol.toStringTag to Compression Streams
6aa1f26 
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@panva @RafaelGSS
stream: yield expected Error class on zlib errors
1aa5a48 
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 30, 2023
@panva @RafaelGSS
test: update WPT files for WebIDL tests
1b5842d 
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@panva @UlisesGascon
stream: add Symbol.toStringTag to Compression Streams
8b1ff5a 
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 12, 2023
@panva @UlisesGascon
stream: add Symbol.toStringTag to Compression Streams
c519e80 
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@panva @UlisesGascon
stream: add Symbol.toStringTag to Compression Streams
1aec6f6 
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@panva @UlisesGascon
stream: add Symbol.toStringTag to Compression Streams
21c61f5 
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@panva panva added backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. labels Dec 15, 2023
@panva
Copy link
Member Author

panva commented Dec 15, 2023 •
edited
Loading

Backport blocked until #50097 is also backported.

UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@panva @UlisesGascon
stream: add Symbol.toStringTag to Compression Streams
23734d5 
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Jan 9, 2024
@panva @UlisesGascon
stream: add Symbol.toStringTag to Compression Streams
4cf155c 
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos targos added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. and removed backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. labels Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@mcollina mcollina mcollina approved these changes

@ljharb ljharb Awaiting requested review from ljharb

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. web streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@panva @nodejs-github-bot @ljharb @mcollina @anonrig @targos