benchmark: remove punycode from require-builtins fixture #50689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's now runtime-deprecated. Remove it from the benchmark. This also gets rid of the warning emitted when the fixture is loaded.
nodejs-github-bot
added
the
benchmark
anonrig
approved these changes
Nov 12, 2023
jasnell
approved these changes
Nov 12, 2023
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Nov 14, 2023
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5a94df4 |
targos
pushed a commit
that referenced
this pull request
Nov 23, 2023
It's now runtime-deprecated. Remove it from the benchmark. This also gets rid of the warning emitted when the fixture is loaded. PR-URL: #50689 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
martenrichter
pushed a commit
to martenrichter/node
that referenced
this pull request
Nov 26, 2023
It's now runtime-deprecated. Remove it from the benchmark. This also gets rid of the warning emitted when the fixture is loaded. PR-URL: nodejs#50689 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
It's now runtime-deprecated. Remove it from the benchmark. This also gets rid of the warning emitted when the fixture is loaded. PR-URL: #50689 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 19, 2023
It's now runtime-deprecated. Remove it from the benchmark. This also gets rid of the warning emitted when the fixture is loaded. PR-URL: #50689 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's now runtime-deprecated. Remove it from the benchmark. This also gets rid of the warning emitted when the fixture is loaded.