-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: add macOS notarization verification step #50628
tools: add macOS notarization verification step #50628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@UlisesGascon looks like this needs a rebase |
Thanks @mhdawson! I was able to solve the conflict directly in the Github UI as it was a simple change. Let me know if this require additional work to be done with the git history :) |
@UlisesGascon for some reason git-node still can't land it. Can you rebase into a single commit ? |
Main Changes
Add a verification step to validate the notarized binaries generated for macOS.
cc: @nodejs/build @nodejs/releasers
Context
Another PR related is #50625
You can find more information in this amazing article https://tonygo.ghost.io/notarization-for-macos-app-with-notarytool/ by @tony-go
Test
This was tested in
iojs+release-ulises-experimental
pipeline in jenkins ci release.case: error
The error was "simulated" by using a different type
Full log available here
case: success
Full log available here