Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: cherry-pick 70caf337c3f6 #50506

Closed
wants to merge 1 commit into from
Closed

deps: V8: cherry-pick 70caf337c3f6 #50506

wants to merge 1 commit into from

Conversation

kxxt
Copy link
Contributor

@kxxt kxxt commented Nov 1, 2023

Original commit message:

[riscv64] Fix the StaticStackFrameSize

 Update the size to kTierupBudgetOffset.

Change-Id: Ibe241211ef67148fae3a4a9eed271f9293ca4801
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585492
Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
Cr-Commit-Position: refs/heads/main@{#79978}

Refs: v8/v8@70caf33

Fixes #50503

@kxxt
deps: V8: cherry-pick 70caf337c3f6
b989f80 
Original commit message:

    [riscv64] Fix the StaticStackFrameSize

     Update the size to kTierupBudgetOffset.

    Change-Id: Ibe241211ef67148fae3a4a9eed271f9293ca4801
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585492
    Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
    Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
    Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#79978}

Refs: v8/v8@70caf33
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Nov 1, 2023
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 1, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 1, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55388/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5642/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5642/

kxxt added a commit to kxxt/archriscv-packages that referenced this pull request Nov 1, 2023
@kxxt
addpatch: nodejs-lts-hydrogen
71898ee 
Backport `[riscv64] Fix the StaticStackFrameSize` to fix vite.

- Upstream issue: nodejs/node#50503
- Upstream PR: nodejs/node#50506
@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5642/

@kxxt kxxt mentioned this pull request Nov 1, 2023
Merged
@targos targos added the riscv64 Issues and PRs related to the riscv64 architecture. label Nov 1, 2023
@richardlau
Copy link
Member

cc @nodejs/platform-riscv64

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55395/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55404/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55416/

felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this pull request Nov 2, 2023
@kxxt @felixonmars
addpatch: nodejs-lts-hydrogen
32d1b2e 
Backport `[riscv64] Fix the StaticStackFrameSize` to fix vite.

- Upstream issue: nodejs/node#50503
- Upstream PR: nodejs/node#50506
@richardlau
Copy link
Member

I've opened a build issue for the Windows failure: nodejs/build#3554

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55425/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55426/

This was referenced Nov 3, 2023
Open
Open
Open
Open
This was referenced Nov 7, 2023
Open
Open
Open
@kxxt
Copy link
Contributor Author

kxxt commented Nov 9, 2023

Hi, any progress here? It's been a week.

@targos
Copy link
Member

targos commented Nov 9, 2023

Don't worry. I'm preparing the next v18.x release and will merge this in due time.

@targos
Copy link
Member

targos commented Nov 27, 2023

Landed in 7af5427

@targos targos closed this Nov 27, 2023
targos pushed a commit that referenced this pull request Nov 27, 2023
@kxxt @targos
deps: V8: cherry-pick 70caf337c3f6
7af5427 
Original commit message:

    [riscv64] Fix the StaticStackFrameSize

     Update the size to kTierupBudgetOffset.

    Change-Id: Ibe241211ef67148fae3a4a9eed271f9293ca4801
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585492
    Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
    Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
    Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#79978}

Refs: v8/v8@70caf33
PR-URL: #50506
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
deps: V8: cherry-pick 70caf337c3f6
383a856 
Original commit message:

    [riscv64] Fix the StaticStackFrameSize

     Update the size to kTierupBudgetOffset.

    Change-Id: Ibe241211ef67148fae3a4a9eed271f9293ca4801
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585492
    Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
    Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
    Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#79978}

Refs: v8/v8@70caf33
PR-URL: nodejs/node#50506
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
deps: V8: cherry-pick 70caf337c3f6
2380ce6 
Original commit message:

    [riscv64] Fix the StaticStackFrameSize

     Update the size to kTierupBudgetOffset.

    Change-Id: Ibe241211ef67148fae3a4a9eed271f9293ca4801
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585492
    Reviewed-by: ji qiu <qiuji@iscas.ac.cn>
    Commit-Queue: Yahan Lu <yahan@iscas.ac.cn>
    Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#79978}

Refs: v8/v8@70caf33
PR-URL: nodejs/node#50506
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. riscv64 Issues and PRs related to the riscv64 architecture. v8 engine Issues and PRs related to the V8 dependency. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kxxt @nodejs-github-bot @richardlau @targos @gengjiawen