Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update cjs-module-lexer to 1.4.0 #50458

Closed
wants to merge 4 commits into from

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Oct 29, 2023

This is an automated update of cjs-module-lexer to 1.4.0.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 29, 2023
@nodejs-github-bot nodejs-github-bot changed the title deps: update cjs-module-lexer to 1.2.3 deps: update cjs-module-lexer to 1.3.0 Apr 28, 2024
@nodejs-github-bot nodejs-github-bot changed the title deps: update cjs-module-lexer to 1.3.0 deps: update cjs-module-lexer to 1.3.1 May 5, 2024
@marco-ippolito marco-ippolito force-pushed the actions/tools-update-cjs-module-lexer branch from 8272d33 to 403c144 Compare May 8, 2024 09:50
@marco-ippolito
Copy link
Member

@nodejs/loaders (I assume this is related to loaders), this update breaks the build

@guybedford
Copy link
Contributor

This update was reverted - nodejs/cjs-module-lexer#95.

Unless progress is made on the PR in nodejs/cjs-module-lexer#98, it will be published with the revert.

@marco-ippolito marco-ippolito added the blocked PRs that are blocked by other issues or PRs. label May 9, 2024
@Pea1594

This comment has been minimized.

@nodejs-github-bot nodejs-github-bot changed the title deps: update cjs-module-lexer to 1.3.1 deps: update cjs-module-lexer to 1.4.0 Sep 1, 2024
@targos
Copy link
Member

targos commented Sep 1, 2024

The build still looks broken.

@targos
Copy link
Member

targos commented Sep 1, 2024

2024-09-01T01:43:13.3207023Z   sccache clang++ -o /home/runner/work/node/node/out/Release/node_mksnapshot -pthread -rdynamic -Wl,--whole-archive /home/runner/work/node/node/out/Release/obj.target/deps/zlib/libzlib.a -Wl,--no-whole-archive -Wl,--whole-archive /home/runner/work/node/node/out/Release/obj.target/deps/uv/libuv.a -Wl,--no-whole-archive -Wl,-z,noexecstack -Wl,--whole-archive /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_snapshot.a -Wl,--no-whole-archive -Wl,-z,relro -Wl,-z,now -Wl,--whole-archive,/home/runner/work/node/node/out/Release/obj.target/deps/openssl/libopenssl.a -Wl,--no-whole-archive -pthread -m64  -Wl,--start-group /home/runner/work/node/node/out/Release/obj.target/node_mksnapshot/src/node_snapshot_stub.o /home/runner/work/node/node/out/Release/obj.target/node_mksnapshot/tools/snapshot/node_mksnapshot.o /home/runner/work/node/node/out/Release/obj.target/libnode.a /home/runner/work/node/node/out/Release/obj.target/deps/histogram/libhistogram.a /home/runner/work/node/node/out/Release/obj.target/deps/sqlite/libsqlite.a /home/runner/work/node/node/out/Release/obj.target/deps/ada/libada.a /home/runner/work/node/node/out/Release/obj.target/deps/nbytes/libnbytes.a /home/runner/work/node/node/out/Release/obj.target/deps/simdjson/libsimdjson.a /home/runner/work/node/node/out/Release/obj.target/deps/simdutf/libsimdutf.a /home/runner/work/node/node/out/Release/obj.target/deps/ncrypto/libncrypto.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_snapshot.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_libplatform.a /home/runner/work/node/node/out/Release/obj.target/tools/icu/libicui18n.a /home/runner/work/node/node/out/Release/obj.target/deps/zlib/libzlib.a /home/runner/work/node/node/out/Release/obj.target/deps/llhttp/libllhttp.a /home/runner/work/node/node/out/Release/obj.target/deps/cares/libcares.a /home/runner/work/node/node/out/Release/obj.target/deps/uv/libuv.a /home/runner/work/node/node/out/Release/obj.target/deps/uvwasi/libuvwasi.a /home/runner/work/node/node/out/Release/obj.target/deps/nghttp2/libnghttp2.a /home/runner/work/node/node/out/Release/obj.target/deps/brotli/libbrotli.a /home/runner/work/node/node/out/Release/obj.target/deps/openssl/libopenssl.a /home/runner/work/node/node/out/Release/obj.target/deps/ngtcp2/libngtcp2.a /home/runner/work/node/node/out/Release/obj.target/deps/ngtcp2/libnghttp3.a /home/runner/work/node/node/out/Release/obj.target/tools/icu/libicuucx.a /home/runner/work/node/node/out/Release/obj.target/tools/icu/libicudata.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_base_without_compiler.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_libbase.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_abseil.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_zlib.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_compiler.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_turboshaft.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_initializers.a /home/runner/work/node/node/out/Release/obj.target/tools/v8_gypfiles/libv8_initializers_slow.a /home/runner/work/node/node/out/Release/obj.target/deps/zlib/libzlib_inflate_chunk_simd.a /home/runner/work/node/node/out/Release/obj.target/deps/zlib/libzlib_adler32_simd.a -latomic -ldl -lm -Wl,--end-group
2024-09-01T01:43:15.4362881Z   LD_LIBRARY_PATH=/home/runner/work/node/node/out/Release/lib.host:/home/runner/work/node/node/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /home/runner/work/node/node/out/Release/obj/gen; "/home/runner/work/node/node/out/Release/node_mksnapshot" "/home/runner/work/node/node/out/Release/obj/gen/node_snapshot.cc"
2024-09-01T01:43:15.4369008Z   LD_LIBRARY_PATH=/home/runner/work/node/node/out/Release/lib.host:/home/runner/work/node/node/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /home/runner/work/node/node/out/Release/obj.target/deps/openssl; /opt/hostedtoolcache/Python/3.12.5/x64/bin/python3 tools/copyfile.py ./deps/openssl/nodejs-openssl.cnf "/home/runner/work/node/node/out/Release/obj.target/deps/openssl/openssl.cnf"
2024-09-01T01:43:15.5765865Z node:internal/deps/cjs-module-lexer/lexer:1444
2024-09-01T01:43:15.5766765Z 
2024-09-01T01:43:15.5766788Z 
2024-09-01T01:43:15.5767358Z 
2024-09-01T01:43:15.5767696Z SyntaxError: Invalid or unexpected token
2024-09-01T01:43:15.5768229Z 
2024-09-01T01:43:15.6577858Z make[2]: *** [node.target.mk:13: /home/runner/work/node/node/out/Release/obj/gen/node_snapshot.cc] Error 1

@guybedford
Copy link
Contributor

I just cloned this branch, built and tested locally, and all seems to be working fine to me. Let me know if I can assist further.

@targos
Copy link
Member

targos commented Sep 2, 2024

Let's try to recreate from scratch

@targos targos closed this Sep 2, 2024
@targos targos deleted the actions/tools-update-cjs-module-lexer branch September 2, 2024 05:41
@targos
Copy link
Member

targos commented Sep 2, 2024

#54713

@guybedford
Copy link
Contributor

Thanks @targos I'm building and testing on Windows so it seems like it's working fine on Windows. I can try a build on my work machine tomorrow if it helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked PRs that are blocked by other issues or PRs. dependencies Pull requests that update a dependency file. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants