Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add needs-ci label to tools/doc #50416

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

richardlau
Copy link
Member

Doc tooling needs to be able to run on builds without internationalization enabled which is only tested in the Jenkins CI.

Refs: #49988 (comment)

Doc tooling needs to be able to run on builds without
internationalization enabled which is only tested in
the Jenkins CI.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 26, 2023
@MoLow
Copy link
Member

MoLow commented Oct 26, 2023

can we enable internationalization on github actions instead?

@aduh95
Copy link
Contributor

aduh95 commented Oct 26, 2023

You mean disable? It will run much slower than Jenkins, but if it's run only for tools PRs, that should be manageable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants