Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: ReadIterable entries may be empty #50398

Merged
merged 1 commit into from
Oct 27, 2023
Merged

src: ReadIterable entries may be empty #50398

merged 1 commit into from
Oct 27, 2023

Conversation

KhafraDev
Copy link
Member

Fixes #49940

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 25, 2023
@KhafraDev KhafraDev force-pushed the readiterable-assertion branch from ee40112 to 4ab7c8a Compare October 25, 2023 21:31
@KhafraDev KhafraDev force-pushed the readiterable-assertion branch from 4ab7c8a to 14cbdf2 Compare October 25, 2023 22:55
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 25, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55240/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 27, 2023
@nodejs-github-bot nodejs-github-bot merged commit e2cf2f0 into nodejs:main Oct 27, 2023
28 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e2cf2f0

@Alexey0312 Alexey0312 mentioned this pull request Oct 27, 2023
Merged
@KhafraDev KhafraDev deleted the readiterable-assertion branch October 27, 2023 22:19
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@KhafraDev @alexfernandez
src: readiterable entries may be empty
3b74897 
fixup

PR-URL: nodejs#50398
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@KhafraDev @targos
src: readiterable entries may be empty
4eb74a2 
fixup

PR-URL: #50398
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@KhafraDev @UlisesGascon
src: readiterable entries may be empty
b7ecb0a 
fixup

PR-URL: #50398
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debadree25 debadree25 debadree25 approved these changes

@H4ad H4ad H4ad approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MessagePort.postMessage with custom iterator as transfer list causes Assertion `(index) < (length())' failed.
5 participants
@KhafraDev @nodejs-github-bot @anonrig @H4ad @debadree25