child_process: fix data loss with readable event #5036
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
child_process
|
I'm tagging this for LTS since the problem is also present in v4.x. It's also a problem with v0.12.9, but the fix may be different -- I haven't looked yet. |
| })); | ||
|
|
||
| p.stdout.read(); | ||
|
|
||
| setTimeout(function() { | ||
| p.kill(); | ||
| }, 100); |
There was a problem hiding this comment.
I removed the timeout here because I'm quite wary of such things as I've seen tests with timeouts like this become flaky.
There was a problem hiding this comment.
you could choose to use common.platformTimeout
setTimeout(function() {
p.kill();
}, common.platformTimeout(100);That should solve the falkyness
|
CI is green except infrastructure-related CI failures. |
|
This same fix should apply fine as-is to v4. I have a separate PR for v0.12 in #5037. |
|
LGTM if the CI is happy |
|
LGTM. Might want to do another CI run. |
| p.on('close', common.mustCall(function(code, signal) { | ||
| assert.strictEqual(code, 0); | ||
| assert.strictEqual(signal, null); | ||
| assert.strictEqual(Buffer.concat(buffer).toString(), '123\n'); |
There was a problem hiding this comment.
Maybe .trim() the result? I'd expect this to fail when the line terminator is \r\n.
There was a problem hiding this comment.
I thought so too, but CI passed on Windows.
There was a problem hiding this comment.
I went ahead and added trim() anyway.
|
LGTM with a suggestion. |
This commit prevents child process stdio streams from being automatically flushed on child process exit/close if a 'readable' event handler has been attached at the time of exit. Without this, child process stdio data can be lost if the process exits quickly and a `read()` (e.g. from a 'readable' handler) hasn't had the chance to get called yet. Fixes: nodejs#5034
mscdex
force-pushed
the
fix-child-process-flush-stdio
branch
from
1f8c83c
to
e528bdc
Compare
|
Adjusted test as suggested. CI again: https://ci.nodejs.org/job/node-test-pull-request/1536/ |
|
Previous CI run had a build bot failure... just to be safe: https://ci.nodejs.org/job/node-test-pull-request/1545/ |
|
LGTM if CI is green |
|
CI seems to be green except for some flaky tests. |
mscdex
added a commit
that referenced
this pull request
Feb 11, 2016
This commit prevents child process stdio streams from being automatically flushed on child process exit/close if a 'readable' event handler has been attached at the time of exit. Without this, child process stdio data can be lost if the process exits quickly and a `read()` (e.g. from a 'readable' handler) hasn't had the chance to get called yet. Fixes: #5034 PR-URL: #5036 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 12274a5. |
rvagg
pushed a commit
that referenced
this pull request
Feb 15, 2016
This commit prevents child process stdio streams from being automatically flushed on child process exit/close if a 'readable' event handler has been attached at the time of exit. Without this, child process stdio data can be lost if the process exits quickly and a `read()` (e.g. from a 'readable' handler) hasn't had the chance to get called yet. Fixes: #5034 PR-URL: #5036 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
stefanmb
pushed a commit
to stefanmb/node
that referenced
this pull request
Feb 23, 2016
This commit prevents child process stdio streams from being automatically flushed on child process exit/close if a 'readable' event handler has been attached at the time of exit. Without this, child process stdio data can be lost if the process exits quickly and a `read()` (e.g. from a 'readable' handler) hasn't had the chance to get called yet. Fixes: nodejs#5034 PR-URL: nodejs#5036 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 1, 2016
This commit prevents child process stdio streams from being automatically flushed on child process exit/close if a 'readable' event handler has been attached at the time of exit. Without this, child process stdio data can be lost if the process exits quickly and a `read()` (e.g. from a 'readable' handler) hasn't had the chance to get called yet. Fixes: #5034 PR-URL: #5036 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 1, 2016
This commit prevents child process stdio streams from being automatically flushed on child process exit/close if a 'readable' event handler has been attached at the time of exit. Without this, child process stdio data can be lost if the process exits quickly and a `read()` (e.g. from a 'readable' handler) hasn't had the chance to get called yet. Fixes: #5034 PR-URL: #5036 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
This commit prevents child process stdio streams from being automatically flushed on child process exit/close if a 'readable' event handler has been attached at the time of exit. Without this, child process stdio data can be lost if the process exits quickly and a `read()` (e.g. from a 'readable' handler) hasn't had the chance to get called yet. Fixes: #5034 PR-URL: #5036 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jun 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prevents child process stdio streams from being automatically flushed on child process exit/close if a 'readable' event handler has been attached at the time of exit.
Without this, child process stdio data can be lost if the process exits quickly and a
read()(e.g. from a 'readable' handler) hasn't had the chance to get called yet.Fixes: #5034