Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasi: fix up wasi tests for ibmi #49953

Merged
merged 2 commits into from
Oct 4, 2023
Merged

wasi: fix up wasi tests for ibmi #49953

merged 2 commits into from
Oct 4, 2023

Conversation

mhdawson
Copy link
Member

ibmi now reports os400 instead of aix

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/wasi

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 29, 2023
@mhdawson
Copy link
Member Author

@richardlau as discussed.

@richardlau richardlau mentioned this pull request Sep 29, 2023
Closed
@richardlau richardlau added the ibm i Issues and PRs related to the IBM i platform. label Sep 29, 2023
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54387/

richardlau
richardlau reviewed Sep 29, 2023
View reviewed changes
test/wasi/c/readdir.c Outdated Show resolved Hide resolved
This was referenced Sep 30, 2023
Open
Open
Open
@richardlau richardlau added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 2, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54478/

@github-actions github-actions bot mentioned this pull request Oct 3, 2023
Open
18 tasks
@mhdawson
Copy link
Member Author

mhdawson commented Oct 3, 2023

@richardlau will take another look to figure out what is going on.

@mhdawson
Copy link
Member Author

mhdawson commented Oct 3, 2023

Turns out the problem is that a newer version of the wasi-sdk has changed behaviour. I used the latest which was version 20. The docs dont' say what version was used before. I'll update the PR to fix up to work with wasi-sdk version 20 and to document that is the version which should be used.

@mhdawson
Copy link
Member Author

mhdawson commented Oct 3, 2023

Ok PR updated, I had to make other changes as well due to other behaviour changes in wask-sdk verison 20, so we'll see if the CI is happy across platforms.

@mhdawson
wasi: fix up wasi tests for ibmi
d7650a3 
ibmi now reports os400 instead of aix

- update platform check in poll to allow for os400
- update wasi-sdk level to 20
  - document the level of wasi-sdk used to compile the tests
  - remove platform check in readdir test as it does not seem to be
    needed with wasi-sdk version 20
  - comment out tests for some clocks which are no longer available when
    compiling with wasi-sdk level 20. These may be added back after
    WebAssembly/wasi-libc#266 is resolved.

Signed-off-by: Michael Dawson <midawson@redhat.com>
@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 3, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 3, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54508/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54517/

@github-actions github-actions bot mentioned this pull request Oct 4, 2023
Open
14 tasks
@richardlau
Copy link
Member

Ok PR updated, I had to make other changes as well due to other behaviour changes in wask-sdk verison 20, so we'll see if the CI is happy across platforms.

This looks good sans the linter failure.
FWIW IBM i CI on d7650a3 shows test-wasi now passing 🎉: https://ci.nodejs.org/job/node-test-commit-ibmi/1314/

@mhdawson
squash: fixup for linter
280a28b 
Signed-off-by: Michael Dawson <midawson@redhat.com>
@mhdawson
Copy link
Member Author

mhdawson commented Oct 4, 2023

Pushed commit to fix linter complaint.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54526/

@mhdawson
Copy link
Member Author

mhdawson commented Oct 4, 2023

osx failure looks like a flaky test - created this issue to track it - #50040

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2023
@nodejs-github-bot nodejs-github-bot merged commit 9cb8eb7 into nodejs:main Oct 4, 2023
27 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 9cb8eb7

This was referenced Oct 5, 2023
Open
Open
Open
Open
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@mhdawson @alexfernandez
wasi: fix up wasi tests for ibmi
b6d4f54 
ibmi now reports os400 instead of aix

- update platform check in poll to allow for os400
- update wasi-sdk level to 20
  - document the level of wasi-sdk used to compile the tests
  - remove platform check in readdir test as it does not seem to be
    needed with wasi-sdk version 20
  - comment out tests for some clocks which are no longer available when
    compiling with wasi-sdk level 20. These may be added back after
    WebAssembly/wasi-libc#266 is resolved.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#49953
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@mhdawson @targos
wasi: fix up wasi tests for ibmi
5b695d6 
ibmi now reports os400 instead of aix

- update platform check in poll to allow for os400
- update wasi-sdk level to 20
  - document the level of wasi-sdk used to compile the tests
  - remove platform check in readdir test as it does not seem to be
    needed with wasi-sdk version 20
  - comment out tests for some clocks which are no longer available when
    compiling with wasi-sdk level 20. These may be added back after
    WebAssembly/wasi-libc#266 is resolved.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #49953
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@mhdawson @debadree25
wasi: fix up wasi tests for ibmi
0475027 
ibmi now reports os400 instead of aix

- update platform check in poll to allow for os400
- update wasi-sdk level to 20
  - document the level of wasi-sdk used to compile the tests
  - remove platform check in readdir test as it does not seem to be
    needed with wasi-sdk version 20
  - comment out tests for some clocks which are no longer available when
    compiling with wasi-sdk level 20. These may be added back after
    WebAssembly/wasi-libc#266 is resolved.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#49953
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. ibm i Issues and PRs related to the IBM i platform. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mhdawson @nodejs-github-bot @richardlau @lpinca @anonrig