Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: replace spurious if with else #49943

Merged
merged 1 commit into from
Sep 29, 2023
Merged

test_runner: replace spurious if with else #49943

merged 1 commit into from
Sep 29, 2023

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Sep 28, 2023

There is an if statement that likely should have been an else in the original PR.

Refs: #48915

@cjihrig
test_runner: replace spurious if with else
1bb2d08 
There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: nodejs#48915
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 28, 2023
@rluvaton rluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54352/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 29, 2023
benjamingr
benjamingr approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be fast tracked

@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 29, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit c935d4c into nodejs:main Sep 29, 2023
43 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c935d4c

@cjihrig cjihrig deleted the cleanup branch September 29, 2023 13:25
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@cjihrig @alexfernandez
test_runner: replace spurious if with else
fade0f4 
There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: nodejs#48915
PR-URL: nodejs#49943
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
targos pushed a commit that referenced this pull request Nov 11, 2023
@cjihrig @targos
test_runner: replace spurious if with else
10b35cf 
There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: #48915
PR-URL: #49943
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@cjihrig @targos
test_runner: replace spurious if with else
1d9c371 
There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: #48915
PR-URL: #49943
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
@targos targos mentioned this pull request Nov 28, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@cjihrig @debadree25
test_runner: replace spurious if with else
0025722 
There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: nodejs#48915
PR-URL: nodejs#49943
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: replace spurious if with else
ad9cae4 
There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: nodejs/node#48915
PR-URL: nodejs/node#49943
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: replace spurious if with else
f0691a1 
There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: nodejs/node#48915
PR-URL: nodejs/node#49943
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

@rluvaton rluvaton rluvaton approved these changes

@MoLow MoLow MoLow approved these changes

@benjamingr benjamingr benjamingr approved these changes

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@cjihrig @nodejs-github-bot @ljharb @benjamingr @MoLow @rluvaton @atlowChemi @LiviaMedeiros @aduh95