Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: update params in jsdoc for HTTPRequestOptions #49872

Merged
merged 1 commit into from
Sep 29, 2023
Merged

lib: update params in jsdoc for HTTPRequestOptions #49872

merged 1 commit into from
Sep 29, 2023

Conversation

pluris
Copy link
Contributor

@pluris pluris commented Sep 26, 2023

A missing parameter was added to the jsdoc of HTTPRequestOptions.

  • joinDuplicateHeaders
  • uniqueHeaders

https://github.com/nodejs/node/blob/main/doc/api/http.md#httprequesturl-options-callback

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. https Issues or PRs related to the https subsystem. needs-ci PRs that need a full CI run. labels Sep 26, 2023
mcollina
mcollina approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54246/

@aduh95 aduh95 added typings and removed needs-ci PRs that need a full CI run. labels Sep 29, 2023
@aduh95 aduh95 merged commit 6aa7101 into nodejs:main Sep 29, 2023
65 of 68 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Sep 29, 2023

Landed in 6aa7101

@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@alexfernandez
lib: update params in jsdoc for HTTPRequestOptions
3fce523 
PR-URL: nodejs#49872
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@pluris pluris deleted the lib/update_jsdoc_http branch November 8, 2023 02:24
targos pushed a commit that referenced this pull request Nov 11, 2023
@targos
lib: update params in jsdoc for HTTPRequestOptions
3e0d47c 
PR-URL: #49872
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@leonardoadame
Copy link

pluris:lib/update_jsdoc_http
#49872 (review)
#49872 (comment)

@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@debadree25
lib: update params in jsdoc for HTTPRequestOptions
aea6fa3 
PR-URL: nodejs#49872
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem. https Issues or PRs related to the https subsystem. typings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pluris @nodejs-github-bot @aduh95 @leonardoadame @mcollina @marco-ippolito