test: replace forEach with for..of in test-http-url #49840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
tniessen
added
the
code-and-learn
|
Hi @niyashiyas note that code and learn issues are usually preferably "one or a few per participant", you've opened 23. I thank you for your help and appreciate your enthusiasm but think it would be preferable to focus on addressing the issues on your other PRs until they land. |
|
To explain these are issues/ideas specifically picked in order to get someone acquainted with the process of contributing to Node.js. Each one you make creates work for project members who need to view the code, run benchmarks and track it. |
niyashiyas
changed the title
lpinca
approved these changes
Oct 6, 2023
lpinca
added
commit-queue-squash
github-actions
bot
removed
the
request-ci
19 tasks
lpinca
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/49840 ✔ Done loading data for nodejs/node/pull/49840 ----------------------------------- PR info ------------------------------------ Title test: replace forEach with for..of in test-http-url (#49840) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch niyashiyas:test-10 -> nodejs:main Labels test, code-and-learn, needs-ci, commit-queue-squash Commits 2 - test: replace forEach with for..of in test-http-url - test: replace forEach with for..of in test-http-url Committers 1 - Niya Shiyas PR-URL: https://github.com/nodejs/node/pull/49840 Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49840 Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 24 Sep 2023 10:12:56 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49840#pullrequestreview-1662401958 ℹ This PR is being fast-tracked because it is from a Code and Learn event ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-10-07T05:17:43Z: https://ci.nodejs.org/job/node-test-pull-request/54592/ - Querying data for job/node-test-pull-request/54592/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6440454179 |
lpinca
pushed a commit
that referenced
this pull request
Oct 7, 2023
PR-URL: #49840 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 2449247. |
This was referenced Oct 8, 2023
24 tasks
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49840 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #49840 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
debadree25
pushed a commit
to debadree25/node
that referenced
this pull request
Apr 15, 2024
PR-URL: nodejs#49840 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced forEach with for in test-http-url.parse-only-support-http-https-protocol.js