Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace forEach with for..of in test-fs-readv.js #49805

Closed
wants to merge 6 commits into from
Closed

test: replace forEach with for..of in test-fs-readv.js #49805

wants to merge 6 commits into from

Conversation

niyashiyas
Copy link
Contributor

replaced forEach with for..of in test-fs-readv.js and test-fs-readv-sync.js

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 23, 2023
tniessen
tniessen reviewed Sep 23, 2023
View reviewed changes
test/parallel/test-fs-readv-sync.js Outdated Show resolved Hide resolved
test/parallel/test-fs-readv-sync.js Outdated Show resolved Hide resolved
test/parallel/test-fs-readv.js Outdated Show resolved Hide resolved
test/parallel/test-fs-readv.js Outdated Show resolved Hide resolved
niyashiyas added a commit to niyashiyas/node that referenced this pull request Sep 24, 2023
@niyashiyas
test: replaced forEach with for..of in test-fs-readv.js nodejs#49805
80ce3aa
@niyashiyas
Copy link
Contributor Author

Made all required changes

@niyashiyas niyashiyas changed the title test: replaced forEach with for..of in test-fs-readv.js test: replace forEach with for..of in test-fs-readv.js Sep 30, 2023
lpinca
lpinca approved these changes Oct 18, 2023
View reviewed changes
test/parallel/test-fs-readv-sync.js Outdated Show resolved Hide resolved
test/parallel/test-fs-readv-sync.js Outdated Show resolved Hide resolved
test/parallel/test-fs-readv.js Outdated Show resolved Hide resolved
test/parallel/test-fs-readv.js Outdated Show resolved Hide resolved
@lpinca lpinca added request-ci Add this label to start a Jenkins CI on a PR. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54973/

@github-actions github-actions bot mentioned this pull request Oct 20, 2023
Open
20 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55080/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55085/

This was referenced Oct 22, 2023
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55410/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55571/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55894/

@aduh95 aduh95 added the stalled Issues and PRs that are stalled. label May 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 5, 2024

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

@github-actions GitHub Actions
Copy link
Contributor

Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.

@github-actions github-actions bot closed this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen left review comments

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. stalled Issues and PRs that are stalled. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@niyashiyas @nodejs-github-bot @jasnell @lpinca @tniessen @aduh95