benchmark: Rename permission-fs-read.js to permission-processhas-fs-read.js #49770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
benchmark
RafaelGSS
reviewed
Sep 22, 2023
There was a problem hiding this comment.
Hi @aki0501
Thank you for your contribution. Can you please adjust the commit message? It must contain the namespace first, in your case, benchmark.
Therefore, your commit message should be: benchmark: rename permission-fs-read.js to permission-processhas-fs-read.js
You can do it by running
git commit --amend -> adjust your message
git push -f origin main
|
Thank you for letting me know! I just modified the commit message and pushed it, I hope that worked. |
RafaelGSS
changed the title
|
Hi @aki0501 looks like you've crossed the limit of a commit length (72 characters). Can you reduce it somehow? Maybe rewording it to:
|
tniessen
added
the
code-and-learn
|
Just fixed it, sorry about that! Thank you again. |
RafaelGSS
added
the
author ready
RafaelGSS
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/49770 ✔ Done loading data for nodejs/node/pull/49770 ----------------------------------- PR info ------------------------------------ Title benchmark: Rename permission-fs-read.js to permission-processhas-fs-read.js (#49770) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aki0501:main -> nodejs:main Labels benchmark, code-and-learn, author ready, permission Commits 1 - benchmark: move permission-fs-read to permission-processhas-fs-read Committers 1 - Aki Hasegawa-Johnson <104283523+aki0501@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/49770 Reviewed-By: Rafael Gonzaga ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49770 Reviewed-By: Rafael Gonzaga -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 22 Sep 2023 18:43:41 GMT ✔ Approvals: 1 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/49770#pullrequestreview-1641080960 ℹ This PR is being fast-tracked because it is from a Code and Learn event ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6438758931 |
nodejs-github-bot
added
the
commit-queue-failed
RafaelGSS
removed
the
commit-queue-failed
|
Landed in 91a21a2, thanks for the contribution |
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49770 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #49770 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #49770 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…esshas-fs-read.js
GHC OSD '23