doc: Fix missing imports in script #49489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
doc
cjihrig
reviewed
Sep 4, 2023
This was referenced Sep 4, 2023
MoLow
reviewed
Sep 4, 2023
MoLow
reviewed
Sep 4, 2023
aduh95
reviewed
Sep 4, 2023
doc/api/test.md
Outdated
| const { tap } = require('node:test/reporters'); | ||
| const { tap, run } = require('node:test/reporters'); | ||
| const process = require('process'); | ||
| const path = require('path'); |
There was a problem hiding this comment.
Suggested change
| const path = require('path'); | |
| const path = require('node:path'); |
meyfa
reviewed
Sep 4, 2023
doc/api/test.md
Outdated
| import process from 'node:process'; | ||
| import path from 'path'; |
There was a problem hiding this comment.
Suggested change
| import path from 'path'; | |
| import path from 'node:path'; |
|
@OshriAsulin I resolved the suggestions you have fixed, there are two more issues raised that are not taken care of:
|
|
@aduh95 ok then I guess we should add it to the CJS example |
No, I don't think so, no one said that the examples need to be a line-by-line equivalent, and it's consistent with most snippets in the docs: CJS ones rely on |
atlowChemi
approved these changes
Sep 6, 2023
|
@OshriAsulin The commit message of first commit should be changed to start with lower case character after the submodule ( Could you rebase and change commit message? |
|
I'd suggest using |
aduh95
approved these changes
Sep 6, 2023
The script was missing necessary imports for the `run` function and the `path` module, causing it to fail. This commit adds the missing imports and resolves the issue. - Import `run` from the appropriate module. - Import `path` to resolve file paths. The script should now run without errors.
This commit enhances the script by addressing missing imports for the 'run' function and the 'path' module, which previously resulted in script failure. The following improvements have been made: Imported 'run' from the appropriate module via require to ensure correct functionality. Imported 'path' via require to facilitate proper file path resolution. Imported 'process' via require to include this essential module. These changes resolve the issue of missing dependencies execution.
In this commit, I've refactored the import statements and destructuring assignments in the codebase to enhance code organization and maintainability. The primary changes are as follows:
1. Replaced the import statement:
- From: `import { tap, run } from 'node:test/reporters';`
- To:
- `import { run } from 'node:test';`
- `import { tap } from 'node:test/reporters';`
2. Reorganized destructuring assignments:
- From:
```
const { tap, run } = require('node:test/reporters');
const process = require('process');
```
- To:
```
const { run } = require('node:test');
const { tap } = require('node:test/reporters');
```
In this commit, I update import and require statements throughout the codebase to use 'node:path' instead of 'path'.
atlowChemi
approved these changes
Sep 6, 2023
atlowChemi
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6919d72 |
|
@OshriAsulin thanks for your contribution! |
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
The script was missing necessary imports for the `run` function and the `path` module, causing it to fail. This commit adds the missing imports and resolves the issue. - Import `run` from the appropriate module. - Import `path` to resolve file paths. The script should now run without errors. PR-URL: #49489 Fixes: #49488 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
The script was missing necessary imports for the `run` function and the `path` module, causing it to fail. This commit adds the missing imports and resolves the issue. - Import `run` from the appropriate module. - Import `path` to resolve file paths. The script should now run without errors. PR-URL: nodejs#49489 Fixes: nodejs#49488 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #49488
The script was missing necessary imports for the 'run' function and the 'path' module, causing it to fail. This commit adds the missing imports and resolves the issue.
The script should now run without errors.