lib: check SharedArrayBuffer availability in freeze_intrinsics.js #49482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
miniak
changed the title
aduh95
approved these changes
Sep 4, 2023
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Sep 4, 2023
aduh95
added
the
commit-queue
targos
approved these changes
Sep 5, 2023
anonrig
approved these changes
Sep 5, 2023
nodejs-github-bot
removed
the
commit-queue
|
Landed in cfe4166 |
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
PR-URL: #49482 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49482 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreaming patch from electron/electron#38571
We would like to be able to use
--frozen-intrinsicsin the renderer process in Electron, which may not haveSharedArrayBufferenabled due to Chromium security policies.