Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: make the NODE_VERSION_IS_RELEASE revert clear #49114

Merged
merged 1 commit into from
Aug 13, 2023
Merged

doc: make the NODE_VERSION_IS_RELEASE revert clear #49114

merged 1 commit into from
Aug 13, 2023

Conversation

RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Aug 11, 2023 •
edited
Loading

Refs: #49084 (comment)

cc: @nodejs/releasers

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 11, 2023
@aduh95
Copy link
Contributor

aduh95 commented Aug 12, 2023

Can you rebase to fix the test failure?

@RafaelGSS RafaelGSS force-pushed the ensure-to-revert-IS_RELEASE branch from 2361d89 to c289765 Compare August 12, 2023 13:47
@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 13, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 13, 2023
@nodejs-github-bot nodejs-github-bot merged commit de4553f into nodejs:main Aug 13, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in de4553f

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS @Ceres6
doc: make the NODE_VERSION_IS_RELEASE revert clear
3df4c7f 
PR-URL: nodejs#49114
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS added a commit that referenced this pull request Aug 15, 2023
@RafaelGSS
doc: make the NODE_VERSION_IS_RELEASE revert clear
7cbada5 
PR-URL: #49114
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS added a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@RafaelGSS
doc: make the NODE_VERSION_IS_RELEASE revert clear
00de8be 
PR-URL: nodejs#49114
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
rluvaton pushed a commit to rluvaton/node that referenced this pull request Aug 15, 2023
@RafaelGSS @rluvaton
doc: make the NODE_VERSION_IS_RELEASE revert clear
b99e3a5 
PR-URL: nodejs#49114
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS added a commit that referenced this pull request Aug 16, 2023
@RafaelGSS
doc: make the NODE_VERSION_IS_RELEASE revert clear
7c83668 
PR-URL: #49114
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS added a commit that referenced this pull request Aug 17, 2023
@RafaelGSS
doc: make the NODE_VERSION_IS_RELEASE revert clear
aa4caf8 
PR-URL: #49114
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2023
@RafaelGSS @targos
doc: make the NODE_VERSION_IS_RELEASE revert clear
79c0497 
PR-URL: #49114
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: make the NODE_VERSION_IS_RELEASE revert clear
406408d 
PR-URL: nodejs/node#49114
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: make the NODE_VERSION_IS_RELEASE revert clear
4a5b7ec 
PR-URL: nodejs/node#49114
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@RafaelGSS @nodejs-github-bot @aduh95 @benjamingr @lpinca @anonrig @atlowChemi