-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
process: trace sync api #48857
Open
theanarkh
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
theanarkh:trace_process_spawn_sync
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
process: trace sync api #48857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
child_process
Issues and PRs related to the child_process subsystem.
needs-ci
PRs that need a full CI run.
labels
Jul 20, 2023
Not sure this triggered coverage failure, cc @bcoe |
@nodejs/coverage-admins This is likely a false positive, any idea to fix this ? |
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jul 25, 2023
theanarkh
force-pushed
the
trace_process_spawn_sync
branch
from
July 25, 2023 18:58
047289b
to
14315c7
Compare
This was referenced Jul 26, 2023
jasnell
approved these changes
Sep 14, 2023
theanarkh
force-pushed
the
trace_process_spawn_sync
branch
from
October 7, 2023 12:22
14315c7
to
145a4ec
Compare
jasnell
approved these changes
Oct 28, 2023
theanarkh
force-pushed
the
trace_process_spawn_sync
branch
from
November 7, 2023 18:19
145a4ec
to
1fc5a98
Compare
@jasnell Hi jasnell, Do you know why coverage checks fail, I haven't seen in other PR 🤔️。 |
theanarkh
force-pushed
the
trace_process_spawn_sync
branch
from
November 23, 2023 14:15
1fc5a98
to
9ce152b
Compare
theanarkh
force-pushed
the
trace_process_spawn_sync
branch
from
February 22, 2024 16:33
9ce152b
to
3f69a63
Compare
aduh95
force-pushed
the
trace_process_spawn_sync
branch
from
May 11, 2024 14:14
3f69a63
to
2b662d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c++
Issues and PRs that require attention from people who are familiar with C++.
child_process
Issues and PRs related to the child_process subsystem.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trace process sync APIs. The example is as follows.
make -j4 test
(UNIX), orvcbuild test
(Windows) passes