V20.5.0 proposal #48761
Merged
V20.5.0 proposal #48761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorder arguments of internal helper functions such that their order is consistent across X509 property getters. Add ReturnPropertyThroughBIO() and ReturnProperty(). Use these new helpers to deduplicate code across various X509 property getters. PR-URL: #48563 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Alba Mendez <me@alba.sh>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.3.6 to 2.20.1. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@83f0fe6...f6e388e) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #48627 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.1.3 to 2.2.0. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@80e868c...08b4669) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #48628 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Instead of many C++ calls, now we make only one C++ call to return a enum number that represents the selected state. PR-URL: #48325 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.4.0 to 2.4.1. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@128a634...55d479f) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #48626 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #48631 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #48632 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Co-Authored-By: haxatron <haxatron1@gmail.com> Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #48564 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.2 to 3.5.3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@8e5e7e5...c85c95e) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> PR-URL: #48625 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Do not install experimental web globals when the environment is initialized with embedder flag `node::EnvironmentFlags::kNoBrowserGlobals`. PR-URL: #48545 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #48551 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #48633 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
This reverts commit 893c000. Refs: #48575 (comment) PR-URL: #48652 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
PR-URL: #48596 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
Fixes: #47321 Refs: https://www.rfc-editor.org/rfc/rfc7540#section-7 PR-URL: #48573 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #48644 Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #48649 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Windows where command lists all places it finds a pattern in Path. The first one is the one that executes when called. So the old code was overriding the first executable by any other match. PR-URL: #48624 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #48665 Reviewed-By: Luke Karrys <luke@lukekarrys.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Clarify that `transform._transform()` callback second argument is used only if the first argument is `null`, i.e. no error occured processing the chunk. PR-URL: #48680 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
When add listener by once, it will be wrapped into another function. And when pass listener and there is just one event listener added by once, it will return 0 even if passed listener equal wrapped event listener. Refs: #46523 PR-URL: #48592 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
It wasn't doing anything, and actually enabling it would cause some tests to fail. Refs: #48576 PR-URL: #48671 Refs: v8/v8@cb00db4 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Original commit message:
[compiler] fix CompileFunction ignoring kEagerCompile
v8::ScriptCompiler::CompileFunction was ignoring kEagerCompile. Unlike
the other functions in v8::ScriptCompiler, it was not actually
propagating kEagerCompile to the parser. The newly updated test fails
without this change.
I did some archeology and found that this was commented out since the
original CL in https://crrev.com/c/980944.
As far as I know Node.js is the main consumer of this particular API.
This CL speeds up Node.js's overall startup time by ~13%.
Change-Id: Ifc3cd6653555194d46ca48db14f7ba7a4afe0053
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4571822
Commit-Queue: Marja Hölttä <marja@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/main@{#87944}
Refs: v8/v8@cb00db4
PR-URL: #48671
Refs: #48576
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #48705 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #48714 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #48550 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #48550 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #48550 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #48550 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
25 tasks
|
CITGM results: |
ruyadorno
approved these changes
Jul 19, 2023
|
ping @lukekarrys for the semver failure |
|
Of the 4 semver failures I saw on v20.5.0 and v20.4.1: 3 were citgm having install issues due to running out of space Output
The other was a timeout due to the OutputI'll look into bumping up the semver timeout for that one test. The test timeout was recently added to catch redos issues. |
22 tasks
|
Is there any chance to bring #48838 to the party? 🎈 |
Oh sorry, I ran out of time with this release and CI is not happy yet with that PR 💔 |
juanarbol
added a commit
that referenced
this pull request
Jul 20, 2023
Notable changes: doc: * add atlowChemi to collaborators (atlowChemi) #48757 events: * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) #48596 fs: * add a fast-path for readFileSync utf-8 (Yagiz Nizipli) #48658 test_runner: * (SEMVER-MINOR) add shards support (Raz Luvaton) #48639 PR-URL: #48761
juanarbol
added a commit
to juanarbol/nodejs.org
that referenced
this pull request
Jul 20, 2023
5 tasks
juanarbol
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Jul 20, 2023
16 tasks
rluvaton
pushed a commit
to rluvaton/node
that referenced
this pull request
Jul 21, 2023
Notable changes: doc: * add atlowChemi to collaborators (atlowChemi) nodejs#48757 events: * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) nodejs#48596 fs: * add a fast-path for readFileSync utf-8 (Yagiz Nizipli) nodejs#48658 test_runner: * (SEMVER-MINOR) add shards support (Raz Luvaton) nodejs#48639 PR-URL: nodejs#48761
This was referenced Jul 22, 2023
pluris
pushed a commit
to pluris/node
that referenced
this pull request
Aug 6, 2023
Notable changes: doc: * add atlowChemi to collaborators (atlowChemi) nodejs#48757 events: * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) nodejs#48596 fs: * add a fast-path for readFileSync utf-8 (Yagiz Nizipli) nodejs#48658 test_runner: * (SEMVER-MINOR) add shards support (Raz Luvaton) nodejs#48639 PR-URL: nodejs#48761
pluris
pushed a commit
to pluris/node
that referenced
this pull request
Aug 7, 2023
Notable changes: doc: * add atlowChemi to collaborators (atlowChemi) nodejs#48757 events: * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) nodejs#48596 fs: * add a fast-path for readFileSync utf-8 (Yagiz Nizipli) nodejs#48658 test_runner: * (SEMVER-MINOR) add shards support (Raz Luvaton) nodejs#48639 PR-URL: nodejs#48761
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Notable changes: doc: * add atlowChemi to collaborators (atlowChemi) nodejs#48757 events: * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) nodejs#48596 fs: * add a fast-path for readFileSync utf-8 (Yagiz Nizipli) nodejs#48658 test_runner: * (SEMVER-MINOR) add shards support (Raz Luvaton) nodejs#48639 PR-URL: nodejs#48761
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Notable changes: doc: * add atlowChemi to collaborators (atlowChemi) nodejs#48757 events: * (SEMVER-MINOR) allow safely adding listener to abortSignal (Chemi Atlow) nodejs#48596 fs: * add a fast-path for readFileSync utf-8 (Yagiz Nizipli) nodejs#48658 test_runner: * (SEMVER-MINOR) add shards support (Raz Luvaton) nodejs#48639 PR-URL: nodejs#48761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2023-07-18, Version 20.5.0 (Current), @juanarbol
Notable Changes
45be29d89f] - doc: add atlowChemi to collaborators (atlowChemi) #48757a316808136] - (SEMVER-MINOR) events: allow safely adding listener to abortSignal (Chemi Atlow) #48596986b46a567] - fs: add a fast-path for readFileSync utf-8 (Yagiz Nizipli) #486580ef73ff6f0] - (SEMVER-MINOR) test_runner: add shards support (Raz Luvaton) #48639Commits
eb0aba59b8] - bootstrap: use correct descriptor for Symbol.{dispose,asyncDispose} (Jordan Harband) #48703e2d0195dcf] - bootstrap: hide experimental web globals with flag kNoBrowserGlobals (Chengzhong Wu) #4854567a1018389] - build: do not pass target toolchain flags to host toolchain (Ivan Trubach) #485977d843bb942] - child_process: use addAbortListener (atlowChemi) #485504e08160f8c] - child_process: supportSymbol.dispose(Moshe Atlow) #48551ef7728bf36] - deps: update nghttp2 to 1.55.1 (Node.js GitHub Bot) #487901454f02499] - deps: update nghttp2 to 1.55.0 (Node.js GitHub Bot) #48746fa94debf46] - deps: update minimatch to 9.0.3 (Node.js GitHub Bot) #48704c73cfcc144] - deps: update acorn to 8.10.0 (Node.js GitHub Bot) #48713b7a076a052] - deps: V8: cherry-pick cb00db4dba6c (Keyhan Vakil) #48671150e15536b] - deps: upgrade npm to 9.8.0 (npm team) #48665c47b2cbd35] - dgram: socket addasyncDispose(atlowChemi) #48717002ce31cca] - dgram: use addAbortListener (atlowChemi) #4855045be29d89f] - doc: add atlowChemi to collaborators (atlowChemi) #4875769b55d2261] - doc: fix ambiguity in http.md and https.md (an5er) #48692caccb051c7] - doc: clarify transform._transform() callback argument logic (Rafael Sofi-zada) #48680999ae0c8c3] - doc: fix copy node executable in Windows (Yoav Vainrich) #486247daefaeb44] - doc: drop <b> of v20 changelog (Rafael Gonzaga) #48649dd7ea3e1df] - doc: mention git node release prepare (Rafael Gonzaga) #48644cc7809df21] - esm: fix emit deprecation on legacy main resolve (Antoine du Hamel) #4866467b13d1dba] - events: fix bug listenerCount don't compare wrapped listener (yuzheng14) #48592a316808136] - (SEMVER-MINOR) events: allow safely adding listener to abortSignal (Chemi Atlow) #48596986b46a567] - fs: add a fast-path for readFileSync utf-8 (Yagiz Nizipli) #48658e4333ac41f] - http2: use addAbortListener (atlowChemi) #485504a0b66e4f9] - http2: send RST code 8 on AbortController signal (Devraj Mehta) #485731295c76fce] - lib: use addAbortListener (atlowChemi) #48550dff6c25a36] - meta: bump actions/checkout from 3.5.2 to 3.5.3 (dependabot[bot]) #48625b5cb69ceaa] - meta: bump step-security/harden-runner from 2.4.0 to 2.4.1 (dependabot[bot]) #48626332e480b46] - meta: bump ossf/scorecard-action from 2.1.3 to 2.2.0 (dependabot[bot]) #4862825c5a0aaee] - meta: bump github/codeql-action from 2.3.6 to 2.20.1 (dependabot[bot]) #486276406f50ab1] - module: add SourceMap.lineLengths (Isaac Z. Schlueter) #48461cfa69bd48c] - net: server addasyncDispose(atlowChemi) #48717ac11264cc5] - net: use addAbortListener (atlowChemi) #4855082d6b13bf6] - permission: add debug log when inserting fs nodes (Rafael Gonzaga) #48677f4333b1cdd] - permission: v8.writeHeapSnapshot and process.report (Rafael Gonzaga) #48564f691dca6c9] - readline: use addAbortListener (atlowChemi) #48550227e6bd898] - src: pass syscall onfs.readFileSyncfail operation (Yagiz Nizipli) #48815a9a4b73653] - src: make BaseObject iteration order deterministic (Joyee Cheung) #48702d99ea4845a] - src: remove kEagerCompile for CompileFunction (Keyhan Vakil) #48671df363d0010] - src: deduplicate X509 getter implementations (Tobias Nießen) #485639cf2e1f55b] - src,lib: reducing C++ calls of esm legacy main resolve (Vinicius Lourenço) #48325daeb21dde9] - stream: fix deadlock when pipeing to full sink (Robert Nagy) #486915a382d02d6] - stream: use addAbortListener (atlowChemi) #485506e82077dd4] - test: deflake test-net-throttle (Luigi Pinca) #48599d378b2c822] - test: move test-net-throttle to parallel (Luigi Pinca) #48599dfa0aee5bf] - Revert "test: remove test-crypto-keygen flaky designation" (Luigi Pinca) #486520ef73ff6f0] - (SEMVER-MINOR) test_runner: add shards support (Raz Luvaton) #48639e2442bb7ef] - timers: support Symbol.dispose (Moshe Atlow) #486334398ade426] - tools: run fetch_deps.py with Python 3 (Richard Lau) #4872938ce95d054] - tools: update doc to unist-util-select@5.0.0 unist-util-visit@5.0.0 (Node.js GitHub Bot) #48714b25e78a998] - tools: update lint-md-dependencies to rollup@3.26.2 (Node.js GitHub Bot) #48705a1f4ff7c59] - tools: update eslint to 8.44.0 (Node.js GitHub Bot) #4863242dc6eb698] - tools: update lint-md-dependencies to rollup@3.26.0 (Node.js GitHub Bot) #4863107bfcc45ab] - url: fixcanParsefalse value when v8 optimizes (Yagiz Nizipli) #48817