Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] net: fix address iteration with autoSelectFamily #48275

Closed
wants to merge 3 commits into from
Closed

[v18.x backport] net: fix address iteration with autoSelectFamily #48275

wants to merge 3 commits into from

Commits on Jul 17, 2023

  1. net: add autoSelectFamily global getter and setter 

    PR-URL: nodejs#45777
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @ShogunPanda @juanarbol
    ShogunPanda authored and juanarbol committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    b209f20 View commit details
    Browse the repository at this point in the history

  2. net: fix family autoselection timeout handling 

    PR-URL: nodejs#47860
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    @ShogunPanda @juanarbol
    ShogunPanda authored and juanarbol committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    6ef172f View commit details
    Browse the repository at this point in the history

  3. net: fix address iteration with autoSelectFamily 

    When `autoSelectFamily` is set to `true`, `net.connect` is supposed to
try connecting to both IPv4 and IPv6, interleaving the address types.
Instead, it appears that the array that holds the addresses in the order
they should be attempted was never used after being populated.

PR-URL: nodejs#48258
Backport-PR-URL: nodejs#48275
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    @indutny @juanarbol
    indutny authored and juanarbol committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    f0d848a View commit details
    Browse the repository at this point in the history