Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: enable zlib AVX-512 optimizations #48228

Closed
wants to merge 4 commits into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented May 28, 2023

This enables AVX-512 optimizations as per https://chromium.googlesource.com/chromium/src/third_party/zlib/+/b890619bc2b193b8fbe9c1c053f4cd19a9791d92%5E%21/#F0. However, build fails. Any suggestion is welcome.

The first commit is from #48218.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@lpinca lpinca force-pushed the enable/avx512-optimizations branch from ab1548f to 666b387 Compare May 28, 2023 07:52
@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem. labels May 28, 2023
@lpinca
Copy link
Member Author

lpinca commented May 28, 2023

cc: @lucshi

@lpinca lpinca force-pushed the enable/avx512-optimizations branch 2 times, most recently from af64b04 to dcc9a3f Compare May 31, 2023 09:55
@lpinca lpinca force-pushed the enable/avx512-optimizations branch from dcc9a3f to 34e6529 Compare June 7, 2023 06:04
@lpinca lpinca closed this Sep 11, 2023
@lpinca lpinca deleted the enable/avx512-optimizations branch September 11, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants