test: fix zlib version regex #48227
Merged
test: fix zlib version regex #48227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
Fixes CI for #48218. |
github-actions
bot
removed
the
request-ci
Mesteery
approved these changes
May 28, 2023
| @@ -61,7 +61,7 @@ assert.match(process.versions.brotli, commonTemplate); | |||
| assert.match(process.versions.llhttp, commonTemplate); | |||
| assert.match(process.versions.node, commonTemplate); | |||
| assert.match(process.versions.uv, commonTemplate); | |||
| assert.match(process.versions.zlib, commonTemplate); | |||
| assert.match(process.versions.zlib, /^\d+\.\d+\.\d+(?:\.\d+)?(?:-.*)?$/); | |||
There was a problem hiding this comment.
Suggested change
| assert.match(process.versions.zlib, /^\d+\.\d+\.\d+(?:\.\d+)?(?:-.*)?$/); | |
| assert.match(process.versions.zlib, /^\d+(?:\.\d+){2,3}(?:-.*)?$/); |
There was a problem hiding this comment.
For consistency I would prefer to keep it as is, see line 72. I'm ok with a a new PR to shorten both regex.
There was a problem hiding this comment.
For me, the reason the first regex wasn't shortened that way is that it would complicate it more than anything else. Unlike this one, which is already a little longer, and in my opinion my suggestion is just as consistent as this regex. But I understand and I don't mind a new PR.
There was a problem hiding this comment.
I'm talking about this one
but I have no strong opinion. I will apply your suggestion.There was a problem hiding this comment.
Oh, you're completly right, sorry for my misunderstanding.
Add support for subrevision in the regular expression for the zlib version. Refs: https://github.com/madler/zlib/blob/48c3741002ac/zlib.h#L40
github-actions
bot
removed
the
request-ci
22 tasks
jasnell
approved these changes
May 29, 2023
lpinca
added
the
commit-queue
23 tasks
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6a6b3c5 |
targos
pushed a commit
that referenced
this pull request
May 30, 2023
Add support for subrevision in the regular expression for the zlib version. Refs: https://github.com/madler/zlib/blob/48c3741002ac/zlib.h#L40 PR-URL: #48227 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 31, 2023
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Add support for subrevision in the regular expression for the zlib version. Refs: https://github.com/madler/zlib/blob/48c3741002ac/zlib.h#L40 PR-URL: #48227 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Add support for subrevision in the regular expression for the zlib version. Refs: https://github.com/madler/zlib/blob/48c3741002ac/zlib.h#L40 PR-URL: nodejs#48227 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Add support for subrevision in the regular expression for the zlib version. Refs: https://github.com/madler/zlib/blob/48c3741002ac/zlib.h#L40 PR-URL: nodejs#48227 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Add support for subrevision in the regular expression for the zlib version. Refs: https://github.com/madler/zlib/blob/48c3741002ac/zlib.h#L40 PR-URL: nodejs#48227 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for subrevision in the regular expression for the zlib version.
Refs: https://github.com/madler/zlib/blob/48c3741002ac/zlib.h#L40