Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "test: unskip negative-settimeout.any.js WPT" #48182

Merged
merged 1 commit into from
May 29, 2023
Merged

Revert "test: unskip negative-settimeout.any.js WPT" #48182

merged 1 commit into from
May 29, 2023

Conversation

panva
Copy link
Member

@panva panva commented May 26, 2023

This reverts commit 8244e6c, PR #47946

nodejs/reliability#577

@panva panva added test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. request-ci Add this label to start a Jenkins CI on a PR. labels May 26, 2023
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 26, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51968/

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 26, 2023
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit c85407d into nodejs:main May 29, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in c85407d

@panva panva deleted the revert-47946 branch May 29, 2023 19:27
targos pushed a commit that referenced this pull request May 30, 2023
@panva @targos
Revert "test: unskip negative-settimeout.any.js WPT"
1dabc73 
This reverts commit 8244e6c.

PR-URL: #48182
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jun 4, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@panva @danielleadams
Revert "test: unskip negative-settimeout.any.js WPT"
37921dc 
This reverts commit 8244e6c.

PR-URL: #48182
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@panva @MoLow
Revert "test: unskip negative-settimeout.any.js WPT"
7250d8c 
This reverts commit 8244e6c.

PR-URL: nodejs#48182
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@panva @Ceres6
Revert "test: unskip negative-settimeout.any.js WPT"
175d2e2 
This reverts commit 8244e6c.

PR-URL: nodejs#48182
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@panva @Ceres6
Revert "test: unskip negative-settimeout.any.js WPT"
ef4b91a 
This reverts commit 8244e6c.

PR-URL: nodejs#48182
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panva @nodejs-github-bot @jasnell @lpinca